Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Skip did_you_mean and delegate failures on MRI 2.7 #7477

Merged
1 commit merged into from Dec 13, 2019

Commits on Dec 13, 2019

  1. Skip did_you_mean and delegate failures on MRI 2.7

    Ruby 2.7 will turn `did_you_mean` into a default gem. That means that
    bundler tests that make sure that an arbritary version of default gems
    can be specified in the `Gemfile` will now run against `did_you_mean`.
    And this doesn't work because `did_you_mean` is activated in ruby's
    `prelude.rb`, way before `bundler/setup` is required, so the latest
    version will always be activated, regardless of what the user specifies.
    If these versions are not the same, a gem activation conflict error will
    happen.
    
    Note that this problem is not specific to ruby 2.7, it simply gets
    triggered by the change of making it a default gem, but it would also
    happen on older versions if the user `did_you_mean` version specified in
    the `Gemfile` does not match the latest version installed on her system.
    
    As a consequence of this, we also get activation trouble because
    `did_you_mean` depends on `delegate` which is also a default gem on ruby
    2.7. This problem _is_ specific to ruby 2.7 because `delegate` was not
    gemified before that, but can probably be workarounded by removing the
    `delegate` dependendcy from `did_you_mean`.
    deivid-rodriguez committed Dec 13, 2019
    Copy the full SHA
    7e56688 View commit details
    Browse the repository at this point in the history