Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Fix bundle exec rake install failing #7474

Merged
5 commits merged into from Dec 12, 2019
Merged

Fix bundle exec rake install failing #7474

5 commits merged into from Dec 12, 2019

Commits on Dec 9, 2019

  1. Copy the full SHA
    d4f96af View commit details
    Browse the repository at this point in the history
  2. Name variable consistenly

    Like it is named in the other analogous methods.
    deivid-rodriguez committed Dec 9, 2019
    Copy the full SHA
    f5a2254 View commit details
    Browse the repository at this point in the history
  3. Extract a gem_command method

    And use it consistently.
    deivid-rodriguez committed Dec 9, 2019
    Copy the full SHA
    cddda67 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. Fix bundle exec rake install not working

    These gem task checks for a specific string in the gem subcommand
    output. However, if we are inside a bundled environment (`bundle exec
    rake install` instead of `rake install`), the ruby process will require
    `bundler/setup` first thing, and initialize a silent UI for rubygems. As
    a result, the output string will be always empty and the condition for
    success will always fail. So, even if installation succeeded, user will
    always be notified of a failure like:
    
    ```
    foo 1.0 built to pkg/foo-1.0.gem.
    rake aborted!
    Couldn't install gem, run `gem install /home/deivid/Code/bundler/tmp/1/bundled_app/pkg/foo-1.0.gem' for more detailed output
    ...
    ```
    
    So, don't check for a specific string in the output and only rely on the
    exit status.
    deivid-rodriguez committed Dec 10, 2019
    Copy the full SHA
    7497037 View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary -I option

    This is leftover code that should've been removed on a previous PR.
    deivid-rodriguez committed Dec 10, 2019
    Copy the full SHA
    aa4488a View commit details
    Browse the repository at this point in the history