This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Turn on warning mode for specs #7422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
turn_on_warning_mode
branch
2 times, most recently
from
3b59032
to
84aa666
Compare
deivid-rodriguez
force-pushed
the
turn_on_warning_mode
branch
from
3cf7f1c
to
fe4ddbf
Compare
|
The only failing specs are now hitting the problem being fixed by #7417, so they should get green after that PR is merged and prevent future warnings from creeping in. |
deivid-rodriguez
force-pushed
the
turn_on_warning_mode
branch
2 times, most recently
from
8ee6937
to
39ab3f7
Compare
deivid-rodriguez
force-pushed
the
turn_on_warning_mode
branch
3 times, most recently
from
82bc2af
to
5c3739f
Compare
deivid-rodriguez
force-pushed
the
turn_on_warning_mode
branch
from
5c3739f
to
dd55808
Compare
|
@bundlerbot merge |
ghost
pushed a commit
that referenced
this pull request
Nov 12, 2019
7422: Turn on warning mode for specs r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that we're missing verbose warnings like the one fixed by #7417. ### What was your diagnosis of the problem? My diagnosis was that our specs should let us know about this. ### What is your fix for the problem, implemented in this PR? My fix is to enable warnings from our helpers that shell out, and fix the warnings they print. There's also some unrelated changes here that I'll try to split out once I get this green. ### Why did you choose this fix out of the possible options? I chose this fix because it makes it so that our specs help us catching these warnings earlier. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded |
ghost
merged commit
deivid-rodriguez
pushed a commit
that referenced
this pull request
Dec 13, 2019
7422: Turn on warning mode for specs r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that we're missing verbose warnings like the one fixed by #7417. ### What was your diagnosis of the problem? My diagnosis was that our specs should let us know about this. ### What is your fix for the problem, implemented in this PR? My fix is to enable warnings from our helpers that shell out, and fix the warnings they print. There's also some unrelated changes here that I'll try to split out once I get this green. ### Why did you choose this fix out of the possible options? I chose this fix because it makes it so that our specs help us catching these warnings earlier. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> (cherry picked from commit 4244534)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that we're missing verbose warnings like the one fixed by #7417.
What was your diagnosis of the problem?
My diagnosis was that our specs should let us know about this.
What is your fix for the problem, implemented in this PR?
My fix is to enable warnings from our helpers that shell out, and fix the warnings they print. There's also some unrelated changes here that I'll try to split out once I get this green.
Why did you choose this fix out of the possible options?
I chose this fix because it makes it so that our specs help us catching these warnings earlier.