This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Improve fileutils require #7156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this broke on ruby 2.3, just like the conditional claimed. I thought this would be compatible judging by the The restriction was changed here: ruby/fileutils#19. At first I thought the motivation was to at least allow installation on Anyways, I'll drop the related commit since the conditional is indeed necessary. |
deivid-rodriguez
force-pushed
the
improve_fileutils_require
branch
from
aaa380f
to
3b77937
Compare
|
This is part of #7062, which has already been approved, but since I had already opened this one, I'll merge this and rebase #7062 on top. @bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
May 12, 2019
7156: Improve fileutils require r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was there's [upstream changes in fileutils](ruby/fileutils#35). ### What is your fix for the problem, implemented in this PR? My fix is to port the upstream changes, which consist of using `require_relative` everywhere. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was there's upstream changes in fileutils.
What is your fix for the problem, implemented in this PR?
My fix is to port the upstream changes, which consist of using
require_relativeeverywhere.