Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Prefer require_relative for internal requires #7100

Merged
7 commits merged into from Apr 23, 2019
Merged

Prefer require_relative for internal requires #7100

7 commits merged into from Apr 23, 2019

Commits on Apr 19, 2019

  1. Remove unnecessary require

    @deivid-rodriguez
    deivid-rodriguez committed Apr 19, 2019
    Copy the full SHA
    e107f3f View commit details
    Browse the repository at this point in the history

  2. Prefer require_relative for internal requires 

    Due to the way rubygems monkey-patched require interacts with default
gems, and given that bundler is a default gem, and that bundler
manipulates the LOAD_PATH in very intricated ways, we can reduce the
risk of "leaking" to a different copy of `bundler` by using
`require_relative` for internal requires.
    @deivid-rodriguez
    deivid-rodriguez committed Apr 19, 2019
    Copy the full SHA
    cf9a288 View commit details
    Browse the repository at this point in the history

  3. Load executable relatively in the first place

    @deivid-rodriguez
    deivid-rodriguez committed Apr 19, 2019
    Copy the full SHA
    e742c3d View commit details
    Browse the repository at this point in the history

  4. Remove dummy comment

    @deivid-rodriguez
    deivid-rodriguez committed Apr 19, 2019
    Copy the full SHA
    c32c7fa View commit details
    Browse the repository at this point in the history

  5. One more

    @deivid-rodriguez
    deivid-rodriguez committed Apr 19, 2019
    Copy the full SHA
    3a82a69 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2019

  1. Add missing require 

    So that the spec can be run in isolation.
    @deivid-rodriguez
    deivid-rodriguez committed Apr 22, 2019
    Copy the full SHA
    c3b917c View commit details
    Browse the repository at this point in the history

  2. Add spec for using relative requires

    @deivid-rodriguez
    deivid-rodriguez committed Apr 22, 2019
    Copy the full SHA
    0dff2a9 View commit details
    Browse the repository at this point in the history