This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Smaller ci matrix #6997
Merged
Smaller ci matrix #6997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree. Thanks for this! @bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Feb 28, 2019
6997: Smaller ci matrix r=colby-swandale a=deivid-rodriguez Fixes #6956. ### What was the end-user problem that led to this PR? The problem was that we have a very slow CI ### What was your diagnosis of the problem? My diagnosis was that the CI matrix is very big, and that old rubies use more resources than new rubies. ### What is your fix for the problem, implemented in this PR? My fix is to remove some entries and when it comes to testing old rubygems version, test only the rubygems version each tested MRI version shipped with. ### Why did you choose this fix out of the possible options? I chose this fix because it saves us some time, and it gives all rubies the same amount of CI resources. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded |
ghost
merged commit 
|
Thanks so much @colby-swandale! I'll now rebase #6957 and get it ready 👍 |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6956.
What was the end-user problem that led to this PR?
The problem was that we have a very slow CI
What was your diagnosis of the problem?
My diagnosis was that the CI matrix is very big, and that old rubies use more resources than new rubies.
What is your fix for the problem, implemented in this PR?
My fix is to remove some entries and when it comes to testing old rubygems version, test only the rubygems version each tested MRI version shipped with.
Why did you choose this fix out of the possible options?
I chose this fix because it saves us some time, and it gives all rubies the same amount of CI resources.