Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Reenable deprecation specs (and make up a plan) #6975

Closed
wants to merge 10 commits into from
Closed

Reenable deprecation specs (and make up a plan) #6975

wants to merge 10 commits into from

Commits on Feb 26, 2019

  1. Teach users how to toggle deprecations off 

    The deprecations will lead to some "true positives" where users will
use `bundle config` and remove the flag, and some "false positives"
where users will be fine with the option not being remembered but still
want to use the flag on a per command basis.

Whatever the case, we need to tell users how to get rid of the warning
once they learn and get ready for the new behavior. Otherwise it's going
to get super annoying!
    @deivid-rodriguez
    deivid-rodriguez committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    11fecfc View commit details
    Browse the repository at this point in the history

  2. Allow a scape valve to keep the old behavior for now

    @deivid-rodriguez
    deivid-rodriguez committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    5c66f4b View commit details
    Browse the repository at this point in the history

  3. Delay requiring --all to update everything to bundler 3 

    Since we haven't even yet deprecated the old behavior.
    @deivid-rodriguez
    deivid-rodriguez committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    aaca317 View commit details
    Browse the repository at this point in the history

  4. Remove messy TODO comments 

    Classic problems, comments do not get as curated as code, so they don't
currently make sense.
    @deivid-rodriguez
    deivid-rodriguez committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    0e64e0d View commit details
    Browse the repository at this point in the history

  5. github.https setting is boolean

    @deivid-rodriguez
    deivid-rodriguez committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    1d3b925 View commit details
    Browse the repository at this point in the history

  6. Remove environmental deprecations 

    Not necessary since no future version will run them.
    @deivid-rodriguez
    deivid-rodriguez committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    c279801 View commit details
    Browse the repository at this point in the history

  7. Switch gems.rb vs Gemfile warning to only warn about multiple gemfiles 

    It's just too early to deprecate "Gemfile", and I don't think this
deprecation was even doing that.
    @deivid-rodriguez
    deivid-rodriguez committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    afbcac5 View commit details
    Browse the repository at this point in the history

  8. Actually switch the default behavior of github sources. 

    This fixes #6910.

The idea here is that we first switch the default source to https, but
not yet deprecate the custom sources, but only making them use http. On
bundler 3 we can actually go and deprecate the sources.
    @jfly @deivid-rodriguez
    jfly authored and deivid-rodriguez committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    0c9592e View commit details
    Browse the repository at this point in the history

  9. Deprecate a bunch of flags in bundler 2 

    Under the previous code, once we stop remembering options, these flags
would be automatically removed without deprecation. Instead, first
deprecate the options in bundler 2, then remove them and stop
remembering them in bundler 3.
    @deivid-rodriguez
    deivid-rodriguez committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    0b3aeeb View commit details
    Browse the repository at this point in the history

  10. Better test description

    @deivid-rodriguez
    deivid-rodriguez committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    7b44d4d View commit details
    Browse the repository at this point in the history