This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Restore 2.0 deprecations #6933
Closed
Restore 2.0 deprecations #6933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including the version is confusing, in my opinion.
deivid-rodriguez
force-pushed
the
restore_2.0_deprecations
branch
2 times, most recently
from
969d391
to
34a0cc3
Compare
Use feature flag instead.
Only left the ones I'm not sure of, and that I think require more thought.
But the check for the major version seems redundant.
deivid-rodriguez
force-pushed
the
restore_2.0_deprecations
branch
from
34a0cc3
to
2d76cea
Compare
This was referenced Jan 26, 2019
Merged
|
I'll now retarget this PR to master, including only the behavior changes (bullet points number 1 and 3 above). |
|
Moved bullet points 1 and 3 to #6965 and changed the description of this PR to reflect that. |
|
We'll most likely cut 2.1 from master, so I'm closing this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that deprecation messages for stuff we want to change in bundler 3 are not yet being displayed.
What was your diagnosis of the problem?
My diagnosis was that we need to make sure we enable deprecations as soon as possible.
What is your fix for the problem, implemented in this PR?
My fix includes several improvements regarding deprecations:
Change the deprecation strategy. Previously deprecations would be always hidden unless the user explicitly turn them on via configuration, or the user is running a "deprecation release", namely, a release with minor level version equal to 99. The new deprecation strategy is simpler: no deprecation releases, and deprecations are turned on by default unless the user turns them off.Moved to Turn on deprecations by default #6965 and targeted to master.Move deprecations back to bundler 2. We moved them to bundler 3, but I think it's fine to deprecate all the stuff in bundler 2, and actually change the behavior in bundler 3. Exceptions are:
Change deprecation message wording. Previous they would read "[DEPRECATED FOR 2.0] <Message about the deprecation>". I find the version in the message a bit confusing so I changed it to just "[DEPRECATED] <Message about the deprecation>".Moved to Turn on deprecations by default #6965 and targeted to master.Why did you choose this fix out of the possible options?
I included all of the improvements in this PR because just moving back the deprecation horizon didn't really fix what I wanted to fix, namely, get the stuff really deprecated in the sense that end users get actual deprecation messages.