This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Stop gemspec requiring dependencies under Bundler #6927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I should be able to make a Gemfile and Gemfile.lock for Bundler with `bundle init --gemspec && bundle lock`. This would allow me to use Bundler to set up an environment for hacking on Bundler, making it compatible with other Bundler-derived tools like Bundix. But, this doesn't work, because the gemspec requires bundler/version, which then requires rubygems. When running under Bundler, requiring rubygems tries to load all of Bundler's development dependencies. This isn't actually necessary just to load the gemspec, so bundler/version shouldn't care if it's running under Bundler and the development dependencies can't be loaded. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # HEAD detached from v2.0.1 # Changes to be committed: # modified: lib/bundler/version.rb # # Untracked files: # Gemfile # Gemfile.lock # nix/ # shell.nix #
alyssais
force-pushed
the
bundler-in-bundler
branch
from
83ab8f0
to
6bfdca1
Compare
|
I’m not sure this is safe — we later call methods on |
|
It should be obvious through an undefined constant or method error, right? It worked fine in by testing, and would definitely have executed |
|
@alyssais Can you provide reproduction steps for this issue? Using bundler for hacking on bundler itself sounds... interesting 😃 |
|
Sure! Here's a Gemfile: source "https://rubygems.org"
gemspecI really just want to use this to install the gems. The reason why I want to do this is a little weird, but it has to do with NixOS, and specifically its Bundix tool. I can go into more detail if required, but I don't think it's that relevant. If I run
But, with my fix applied, I can successfully install the gems. |
|
I'm pretty sure #7062 is a better approach to this, and I also tried that PR for your situation and it worked, so I'll close this, ok? |
ghost
pushed a commit
that referenced
this pull request
May 12, 2019
7062: Remove version overwriting hacks r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that we are doing some hacks in our version file that are... dangerous. At very least they cause "circular problems" like #6927, but I also have bad feelings about it. ### What was your diagnosis of the problem? My diagnosis was we're overwriting the version of the currently loaded bundler 😬. This hack is _almost_ unnecessary (see the spec run here with the hack fully removed: https://travis-ci.org/bundler/bundler/builds/509497021. Only three jobs failed, and for old rubies/rubygems/bundler). ### What is your fix for the problem, implemented in this PR? My fix is to limit the hack to `bundler`'s spec run, since it's only needed there. ### Why did you choose this fix out of the possible options? I chose this fix because fully getting the build green with the hack fully removed is a bit of work. I dedicated a bit of time to investigate one of the failures and it all comes down to the priority of loading default gems vs `-I`. So I think something like rubygems/rubygems#1868 should fix it. But that's out of the scope of this PR. Closes #6927. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that I couldn't use Bundler to set up an environment for hacking on Bundler, making it compatible with other Bundler-derived tools like Bundix.
What was your diagnosis of the problem?
My diagnosis was that the gemspec requires bundler/version, which then requires rubygems. When running under Bundler, requiring rubygems tries to load all of Bundler's development dependencies.
What is your fix for the problem, implemented in this PR?
My fix is to ignore missing development dependencies in bundler/version, so that it can be loaded by the gemspec under Bundler.
Why did you choose this fix out of the possible options?
I chose this fix because I don't see any other ones, and I don't think this should have any impact outside of this edge case.