Don't check for the existence of a writable home directory if BUNDLE_USER_HOME is set #6885
Conversation
|
Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack. For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide |
|
This looks good, can you please add a test for this? |
|
@segiddins - I believe testing is covered by the change I made to |
There was a problem hiding this comment.
This PR looks good to me as is. @segiddins do you have any additional coverage in mind?
|
No further feedback so let's do this! @bundlerbot r+ |
6885: Don't check for the existence of a writable home directory if BUNDLE_USER_HOME is set r=deivid-rodriguez a=jturkel #6024 added support for specifying an alternate bundler home directory via the `BUNDLE_USER_HOME` environment variable. Unfortunately bundler still checks for a writable user home directory even if the `BUNDLE_USER_HOME` override is specified resulting in warnings like this: ``` `/home/appuser` is not a directory. Bundler will use `/tmp/bundler/home/unknown' as your home directory temporarily. ``` The fix for this problem is to only evaluate bundler path fallbacks if environment variable overrides are not specified. Co-authored-by: Joel Turkel <jturkel@salsify.com>
Build succeeded |
ghost
merged commit 
|
Bundler 2.0.2 (released 5 days ago) does not include this change. Are you planning it for future versions? |
#6024 added support for specifying an alternate bundler home directory via the
BUNDLE_USER_HOMEenvironment variable. Unfortunately bundler still checks for a writable user home directory even if theBUNDLE_USER_HOMEoverride is specified resulting in warnings like this:The fix for this problem is to only evaluate bundler path fallbacks if environment variable overrides are not specified.