This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
fix installing gems on _really_ old versions of RubyGems #6840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colby-swandale
force-pushed
the
colby/fix-gem-installation-bundler-1
branch
from
55604b0
to
780c8ea
Compare
hsbt
approved these changes
Dec 18, 2018
|
Thanks! |
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Dec 18, 2018
6840: fix installing gems on _really_ old versions of RubyGems r=segiddins a=colby-swandale ### What was the end-user problem that led to this PR? Installing gems on _really really_ old versions of RubyGems is not working. See #6839 ### What was your diagnosis of the problem? We were accessing an instance variable which did not exist ### What is your fix for the problem, implemented in this PR? instantiate the instance variable ourselves. ### Why did you choose this fix out of the possible options? This was the simplest solution that can be easily merged with `1-17-stable` Fixes #6839 Co-authored-by: Colby Swandale <me@colby.fyi>
Timed out |
|
@bundlerbot r+ |
|
@bundlerbot retry |
|
Not awaiting review |
ghost
pushed a commit
that referenced
this pull request
Dec 19, 2018
6840: fix installing gems on _really_ old versions of RubyGems r=colby-swandale a=colby-swandale ### What was the end-user problem that led to this PR? Installing gems on _really really_ old versions of RubyGems is not working. See #6839 ### What was your diagnosis of the problem? We were accessing an instance variable which did not exist ### What is your fix for the problem, implemented in this PR? instantiate the instance variable ourselves. ### Why did you choose this fix out of the possible options? This was the simplest solution that can be easily merged with `1-17-stable` Fixes #6839 Co-authored-by: Colby Swandale <me@colby.fyi>
Timed out |
|
Oh, i think there is some missing config bors needs for this branch to be merged |
|
Ah, You can merge this manually or backport bors configuration from master branch. |
colby-swandale
force-pushed
the
colby/fix-gem-installation-bundler-1
branch
from
80789f1
to
576c6d1
Compare
|
@bundlerbot r+ |
colby-swandale
force-pushed
the
colby/fix-gem-installation-bundler-1
branch
from
576c6d1
to
ac81731
Compare
|
@bundlerbot retry |
colby-swandale
force-pushed
the
colby/fix-gem-installation-bundler-1
branch
from
ac81731
to
d47cbc2
Compare
|
@bundlerbot retry |
|
@bundlerbot r+ |
|
Not awaiting review |
3 similar comments
|
Not awaiting review |
|
Not awaiting review |
|
Not awaiting review |
|
@bundlerbot r+ |
|
Not awaiting review |
1 similar comment
|
Not awaiting review |
ghost
pushed a commit
that referenced
this pull request
Dec 27, 2018
6840: fix installing gems on _really_ old versions of RubyGems r=colby-swandale a=colby-swandale ### What was the end-user problem that led to this PR? Installing gems on _really really_ old versions of RubyGems is not working. See #6839 ### What was your diagnosis of the problem? We were accessing an instance variable which did not exist ### What is your fix for the problem, implemented in this PR? instantiate the instance variable ourselves. ### Why did you choose this fix out of the possible options? This was the simplest solution that can be easily merged with `1-17-stable` Fixes #6839 Co-authored-by: Colby Swandale <me@colby.fyi>
Build succeeded |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
Installing gems on really really old versions of RubyGems is not working. See #6839
What was your diagnosis of the problem?
We were accessing an instance variable which did not exist
What is your fix for the problem, implemented in this PR?
instantiate the instance variable ourselves.
Why did you choose this fix out of the possible options?
This was the simplest solution that can be easily merged with
1-17-stableFixes #6839