This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Add --skip-install flag to bundle add #6517
Merged
bundlerbot
merged 2 commits into
rubygems:master
from
agrim123:agr-bundler-add-skip-install
May 20, 2018
Merged
Add --skip-install flag to bundle add #6517
bundlerbot
merged 2 commits into
rubygems:master
from
agrim123:agr-bundler-add-skip-install
May 20, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrim123
force-pushed
the
agr-bundler-add-skip-install
branch
from
May 2, 2018 11:39
b9c91d9
to
c8f9836
Compare
segiddins
approved these changes
May 3, 2018
lib/bundler/cli.rb
Outdated
@@ -333,7 +333,8 @@ def binstubs(*gems) | |||
method_option "version", :aliases => "-v", :type => :string | |||
method_option "group", :aliases => "-g", :type => :string | |||
method_option "source", :aliases => "-s", :type => :string | |||
|
|||
method_option "skip-install", :type => :boolean, :banner => | |||
"Adds gem to gemfile but does not install it" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool addition!
Suggestion: harmonize wording with the rest of the options: to gemfile
=> to the Gemfile
. (In this file and and in the .ronn documentation.)
agrim123
force-pushed
the
agr-bundler-add-skip-install
branch
from
May 14, 2018 13:19
c8f9836
to
dddfcf2
Compare
Thanks! @bundlerbot r+ |
📌 Commit dddfcf2 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
May 20, 2018
…swandale Add --skip-install flag to bundle add Usage ```bash bundle add rack --skip-install ``` This flag would not install the gem, only add it to the gemfile. Closes #6511
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage
This flag would not install the gem, only add it to the gemfile.
Closes #6511