Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Correctly re-install extensions when running pristine for a git source #6303

Closed
wants to merge 1 commit into from

Conversation

wagenet
Copy link
Contributor

@wagenet wagenet commented Feb 22, 2018

Unfortunately, I was unable to figure out how to prevent it from reloading
the built extension from the global cache in 2.0. That means this is 1.16
only for now. I will investigate more.

Resolves #6294

@ghost
Copy link

ghost commented Feb 22, 2018

Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack.

For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide

@wagenet
Copy link
Contributor Author

wagenet commented Feb 22, 2018

@colby-swandale I agree, but as you can see from my comment, I was unable to get it to work on master due to my inability to clear the entry from the global cache.

@wagenet
Copy link
Contributor Author

wagenet commented Feb 22, 2018

@colby-swandale the issue I'm seeing is that for git gems, instead or actually rebuilding, we're just loading from bundler_extension_cache_path.

https://github.com/bundler/bundler/blob/master/lib/bundler/rubygems_gem_installer.rb#L22

I believe the solution would either be to have the force option be true or to delete the extension_cache entry. Do you have a suggestion on which is preferable?

@wagenet
Copy link
Contributor Author

wagenet commented Feb 22, 2018

Reopened in #6305 with a potential solution.

@wagenet wagenet closed this Feb 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant