This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
add --paths option to bundle list command.
#6177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option mimics the `--paths` options in `bundle show` which is being removed in bundler 2. Example Usage: $ bundle list --paths /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actioncable-5.1.4 /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actionmailer-5.1.4 /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actionpack-5.1.4 /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actionview-5.1.4
|
\cc @indirect |
segiddins
reviewed
Nov 22, 2017
| @@ -285,6 +285,7 @@ def show(gem_name = nil) | |||
| if Bundler.feature_flag.list_command? | |||
| desc "list", "List all gems in the bundle" | |||
| method_option "name-only", :type => :boolean, :banner => "print only the gem names" | |||
| method_option "paths", :type => :boolean, :banner => "print the path to each gem in the bundle" | |||
There was a problem hiding this comment.
what happens if you pass bundle list --paths --name-only?
There was a problem hiding this comment.
Bundler will just print the same output as bundler list --name-only
There was a problem hiding this comment.
we probably should make it an error if both are passed, then
segiddins
reviewed
Nov 22, 2017
spec/commands/list_spec.rb
Outdated
| context "with paths option" do | ||
| before do | ||
| install_gemfile <<-G | ||
| source "file://#{gem_repo1}" |
There was a problem hiding this comment.
let's also include a :git gem and a gemspec gem for good measure?
…n --only-names + --paths are used together
|
ping @indirect |
|
Yep, this looks right! Let’s do it. @bundlerbot r+ |
|
📌 Commit 830e95f has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Jan 8, 2018
add `--paths` option to `bundle list` command. See #6172 This option mimics the `--paths` options in `bundle show` which is being removed in Bundler 2. Example Usage: ``` $ bundle list --paths /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actioncable-5.1.4 /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actionmailer-5.1.4 /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actionpack-5.1.4 /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actionview-5.1.4 ```
|
☀️ Test successful - status-travis |
colby-swandale
pushed a commit
that referenced
this pull request
Sep 20, 2018
add `--paths` option to `bundle list` command. See #6172 This option mimics the `--paths` options in `bundle show` which is being removed in Bundler 2. Example Usage: ``` $ bundle list --paths /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actioncable-5.1.4 /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actionmailer-5.1.4 /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actionpack-5.1.4 /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actionview-5.1.4 ``` (cherry picked from commit e39f7aa)
colby-swandale
pushed a commit
that referenced
this pull request
Oct 5, 2018
add `--paths` option to `bundle list` command. See #6172 This option mimics the `--paths` options in `bundle show` which is being removed in Bundler 2. Example Usage: ``` $ bundle list --paths /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actioncable-5.1.4 /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actionmailer-5.1.4 /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actionpack-5.1.4 /Users/c/Desktop/Projects/testapp/.bundle/ruby/2.4.0/gems/actionview-5.1.4 ``` (cherry picked from commit e39f7aa)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6172
This option mimics the
--pathsoptions inbundle showwhich isbeing removed in Bundler 2.
Example Usage: