check permissions in doctor command #6129

ajwann · 2017-10-29T16:29:03Z

Thanks so much for the contribution!
To make reviewing this PR a bit easier, please fill out answers to the following questions.

What was the end-user problem that led to this PR?

The problem was...
#5786

We should have a check in bundle doctor for the file/folder permissions in the Bundler home directory.

We should print a warning if there are any files/folders that is owned by another user but is readable/writable but prints an error when a file cannot be read or written to.

What is your fix for the problem, implemented in this PR?

Created private method check_home_permissions that will print a warning if there are any files/folders that are owned by another user but are readable/writable, and print an error when the
bundler home dir contains a file cannot be read or written to

Why did you choose this fix out of the possible options?

I chose this fix because it's what was requested in the open issue.

ajwann · 2017-11-20T11:26:12Z

It turns out ./spec/quality_es_spec.rb was breaking because I missed one more vim .swp file.

ajwann · 2017-11-20T12:02:23Z

lib/bundler/cli/doctor.rb

@@ -61,6 +62,7 @@ def check!
    end

    def run
+      check_home_permissions


I'm not sure if this is the best place to put the new home permissions check, it just jumped out to me as the most convenient. I'm happy to move it around if there is a more appropriate place.

ajwann · 2017-11-20T12:04:45Z

lib/bundler/cli/doctor.rb

+
+    def check_for_files_not_readable_or_writable
+      return unless any_files_not_readable_or_writable?
+      raise ProductionError, "Files exist in Bundler home that are not " \


I chose to raise ProductionError because I saw it being raised in the run method; if I should raise a different error please let me know.

I don't agree with using exceptions as part of regular program behavior flow. I suggest printing a message to the user using Bundler.ui.info instead.

colby-swandale · 2017-11-26T03:41:36Z

lib/bundler/cli/doctor.rb

+
+    def check_for_files_not_owned_by_current_user_but_still_rw
+      return unless any_files_not_owned_by_current_user_but_still_rw?
+      Bundler.ui.warn "Files exist in Bundler home that are owned by another " \


We want to say which files are not owned by the user or cannot be read/written to. The current error message does not have much value to the user as we're leaving it up to the user to go looking in the bundler dir to see which file(s) have the problem.

colby-swandale · 2017-11-26T03:47:30Z

lib/bundler/cli/doctor.rb

+
+    def check_for_files_not_readable_or_writable
+      return unless any_files_not_readable_or_writable?
+      raise ProductionError, "Files exist in Bundler home that are not " \


I don't agree with using exceptions as part of regular program behavior flow. I suggest printing a message to the user using Bundler.ui.info instead.

segiddins · 2017-11-28T00:55:14Z

lib/bundler/cli/doctor.rb

      Bundler.ui.warn "Files exist in Bundler home that are owned by another " \
-        "user, but are stil readable/writable"
+        "user, but are stil readable/writable. These files are: #{files_not_owned_by_current_user_but_still_rw.join("\n")}"


maybe These files are:\n - #{files.join("\n - ")} so theres some more visual differentiation?

Right now, this is the output I get:

Files exist in Bundler home that are not readable/writable to the current user. These files are: /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/CLAide-7f26d3d016ef/.git/objects/pack/pack-37fe8b0ecb7fb4bb549140a193f9b3e5f57bd982.idx /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/CLAide-7f26d3d016ef/.git/objects/pack/pack-37fe8b0ecb7fb4bb549140a193f9b3e5f57bd982.pack /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/Core-df21f20a2825/.git/objects/pack/pack-6a6bf20937cabbe439abad31192fb692d6585ae9.idx /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/Core-df21f20a2825/.git/objects/pack/pack-6a6bf20937cabbe439abad31192fb692d6585ae9.pack /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/Core-df6877912172/.git/objects/pack/pack-2c1d1f2113e0f0d1aa8cc9bbf30f63fc862dc08f.idx /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/Core-df6877912172/.git/objects/pack/pack-2c1d1f2113e0f0d1aa8cc9bbf30f63fc862dc08f.pack /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/Molinillo-b17c754d2b93/.git/objects/pack/pack-3d267bb97f882693d85a6e1b2851f665109fae4e.idx /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/Molinillo-b17c754d2b93/.git/objects/pack/pack-3d267bb97f882693d85a6e1b2851f665109fae4e.pack /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/Molinillo-b17c754d2b93/.git/objects/pack/pack-933914d968c3dd6509e6a5566f17d21f147f12f8.idx /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/Molinillo-b17c754d2b93/.git/objects/pack/pack-933914d968c3dd6509e6a5566f17d21f147f12f8.pack /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/Molinillo-c2f655cd6978/.git/objects/pack/pack-d63e0ec18a4aac8667d7c0bfc3deac537ad1f9f0.idx /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/Molinillo-c2f655cd6978/.git/objects/pack/pack-d63e0ec18a4aac8667d7c0bfc3deac537ad1f9f0.pack /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/Nanaimo-c9b1cf573452/.git/objects/pack/pack-20dc04ae125dbd210206bbb95986cf199c46d0e9.idx /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/Nanaimo-c9b1cf573452/.git/objects/pack/pack-20dc04ae125dbd210206bbb95986cf199c46d0e9.pack /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/Xcodeproj-4279382c6003/.git/objects/pack/pack-5584e2008093ac49ed59feb9082ee93cd70f0cc1.idx /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/Xcodeproj-4279382c6003/.git/objects/pack/pack-5584e2008093ac49ed59feb9082ee93cd70f0cc1.pack /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/Xcodeproj-d9be15fd7ac9/.git/objects/pack/pack-e4ebf9f8c265c099ac1869bd0b4c5ea222053a54.idx /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/Xcodeproj-d9be15fd7ac9/.git/objects/pack/pack-e4ebf9f8c265c099ac1869bd0b4c5ea222053a54.pack /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/cocoapods-deintegrate-3735087ac0d5/.git/objects/pack/pack-a08336c992731d0640ff4d3f6adb02131d2a8d5a.idx /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/cocoapods-deintegrate-3735087ac0d5/.git/objects/pack/pack-a08336c992731d0640ff4d3f6adb02131d2a8d5a.pack /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/cocoapods-downloader-74c8d27df0bf/.git/objects/pack/pack-7da53b6d4c74635672bcb2c8455171f14c79bdeb.idx /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/cocoapods-downloader-74c8d27df0bf/.git/objects/pack/pack-7da53b6d4c74635672bcb2c8455171f14c79bdeb.pack /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/cocoapods-plugins-c222b56ed644/.git/objects/pack/pack-23621f86d62c2e1c0722acb0f5621fac307f383b.idx /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/cocoapods-plugins-c222b56ed644/.git/objects/pack/pack-23621f86d62c2e1c0722acb0f5621fac307f383b.pack /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/cocoapods-search-eb60c856fc55/.git/objects/pack/pack-a86b94fa0bd854a521d7c6ab65bd67a27f9645d1.idx /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/cocoapods-search-eb60c856fc55/.git/objects/pack/pack-a86b94fa0bd854a521d7c6ab65bd67a27f9645d1.pack /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/cocoapods-stats-5eaccbc74899/.git/objects/pack/pack-4745e20dba5624f24613c734914364f70a54d5b3.idx /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/cocoapods-stats-5eaccbc74899/.git/objects/pack/pack-4745e20dba5624f24613c734914364f70a54d5b3.pack /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/cocoapods-trunk-649ccab360b3/.git/objects/pack/pack-a247d31191008395fabda8c36ac8e3ddbbd106d7.idx /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/cocoapods-trunk-649ccab360b3/.git/objects/pack/pack-a247d31191008395fabda8c36ac8e3ddbbd106d7.pack /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/cocoapods-trunk-a3d9e816e04b/.git/objects/pack/pack-cd3508e822e9ee6bf974849b8194a8db6222088e.idx /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/cocoapods-trunk-a3d9e816e04b/.git/objects/pack/pack-cd3508e822e9ee6bf974849b8194a8db6222088e.pack /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/cocoapods-try-2c0840a6ba64/.git/objects/pack/pack-7189861dc396805fd212e6aaee59813717ac8d4b.idx /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/cocoapods-try-2c0840a6ba64/.git/objects/pack/pack-7189861dc396805fd212e6aaee59813717ac8d4b.pack /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/json-a9588bc4334c/.git/objects/pack/pack-4da8020924009c5291978ebe90f221cb3d33943f.idx /Users/segiddins/Development/Rainforest/CocoaPods/.bundle/ruby/2.4.0/bundler/gems/json-a9588bc4334c/.git/objects/pack/pack-4da8020924009c5291978ebe90f221cb3d33943f.pack

segiddins · 2017-12-01T17:39:23Z

Hey @ajwann, I made a few small changes, if you want to look them over. @colby-swandale r?

ajwann · 2017-12-02T17:58:14Z

@segiddins you're changes look good to me! Thanks for your help.

colby-swandale · 2017-12-04T20:12:17Z

lib/bundler/cli/doctor.rb

+      files_not_readable_or_writable = []
+      files_not_owned_by_current_user_but_still_rw = []
+      Find.find(Bundler.home.to_s).each do |f|
+        if !File.writable?(f) || !File.readable?(f)


My only concern here is that a file can be not readable/writable and also be owned by a different user.

@segiddins, @colby-swandale I can add that functionality if it's needed

olleolleolle

Cool PR!

I made inline comments on details where I had questions as a reader.

olleolleolle · 2017-12-25T08:34:01Z

lib/bundler/cli/doctor.rb

+      ok = true
+      if files_not_owned_by_current_user_but_still_rw.any?
+        Bundler.ui.warn "Files exist in the Bundler home that are owned by another " \
+          "user, but are stil readable/writable. These files are:\n - #{files_not_owned_by_current_user_but_still_rw.join("\n - ")}"


Typo: stil => still

(String also appears in the tests.)

olleolleolle · 2017-12-25T08:34:30Z

lib/bundler/cli/doctor.rb

+
+      if files_not_readable_or_writable.any?
+        Bundler.ui.warn "Files exist in the Bundler home that are not " \
+          "readable/writable to the current user. These files are:\n - #{files_not_readable_or_writable.join("\n - ")}"


Grammar note: to the current user => by the current user

(String also appears in the tests.)

olleolleolle · 2017-12-25T08:36:31Z

lib/bundler/cli/doctor.rb

@@ -86,9 +88,41 @@ def run
          end
        end.flatten.sort.each {|m| message += m }
        raise ProductionError, message
-      else
+      elsif !permissions_valid


Question: Is there a ! too much in this conditional?

I personally like how @segiddins implemented the permissions_valid method to be truthy, and then negated it. I prefer having a truthy method like permissions_valid with a negation, as opposed to a falsy method (like permissions_invalid), with no negation.

That's just my preference though, and if anyone has a counterargument I'm open to hearing it.

olleolleolle · 2017-12-25T08:37:54Z

spec/commands/doctor_spec.rb

@@ -58,4 +57,35 @@
       * rack: /usr/local/opt/icu4c/lib/libicui18n.57.1.dylib
    E
  end
+
+  it "exits with an error if home contains files that are not read/write" do


Perhaps: read/write => readable/writable?

ajwann · 2018-01-04T11:41:58Z

@olleolleolle I appreciate the feedback and I'm fine with making those changes. @segiddins I should have time this weekend to wrap up this PR.

segiddins · 2018-01-13T04:23:50Z

Thanks @ajwann !

ajwann · 2018-01-14T16:26:56Z

@olleolleolle, @segiddins and @colby-swandale; this PR should be good to go. Please let me know if you guys need any additional changes!

colby-swandale · 2018-01-14T22:23:31Z

spec/commands/doctor_spec.rb

@@ -58,4 +57,51 @@
       * rack: /usr/local/opt/icu4c/lib/libicui18n.57.1.dylib
    E
  end
+
+  it "exits with an error if home contains files that are not readable/writable" do


These tests can be wrapped with context blocks.

it 'exits with an error if home contains files that are not readable/writable'`

can be better written as:

context 'when home contains files that are not readable/writable' it 'exits with an error'

It also means that we can move some of setup for these tests into before blocks

(Same applies to the other specs)

colby-swandale · 2018-01-14T22:27:17Z

spec/commands/doctor_spec.rb

+      gem "rack"
+    G
+
+    stat = double("stat")


Do we need these to be applied for every test in the file? i would wrap these and the check file permission specs in a describe so we keep everything close and only use these we're needed.

We need that double on line 15 to be applied for every test, because we need the existing tests to be able to stat their files and see that they were created by the current user (Process.uid)

ajwann · 2018-01-15T15:18:47Z

@colby-swandale I think I've dried up the tests as much as can be, but if you see something specific let me know.

ajwann · 2018-01-25T20:02:45Z

I'm not sure why the build failed here, since all I did was squash some commits. I re-ran ./spec/commands/exec_spec.rb:759 locally on the same version of Ruby as the build, 2.5.0, and had no issues. I've force pushed a new sha for my last commit to kick of Travis again.

ajwann · 2018-01-25T20:36:19Z

It looks like the build keeps failing on ./spec/commands/exec_spec.rb:759, due to an OpenSSL issue. I can't reproduce this failure locally so that makes me believe one of the Travis builds really does have an ssl issue. Can anyone from the core team comment on this?

colby-swandale · 2018-01-27T01:24:07Z

#6275 should fix this issue

colby-swandale · 2018-01-31T09:45:22Z

@bundlerbot r+

bundlerbot · 2018-01-31T09:45:23Z

📌 Commit d82a9ef has been approved by colby-swandale

bundlerbot · 2018-01-31T09:45:27Z

⌛ Testing commit d82a9ef with merge fe9d698...

…olby-swandale check permissions in doctor command Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. ### What was the end-user problem that led to this PR? The problem was... #5786 > We should have a check in bundle doctor for the file/folder permissions in the Bundler home directory. >We should print a warning if there are any files/folders that is owned by another user but is readable/writable but prints an error when a file cannot be read or written to. ### What is your fix for the problem, implemented in this PR? Created private method ```check_home_permissions``` that will print a warning if there are any files/folders that are owned by another user but are readable/writable, and print an error when the bundler home dir contains a file cannot be read or written to ### Why did you choose this fix out of the possible options? I chose this fix because it's what was requested in the open issue.

bundlerbot · 2018-01-31T10:13:56Z

☀️ Test successful - status-travis
Approved by: colby-swandale
Pushing fe9d698 to master...

…olby-swandale check permissions in doctor command Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. ### What was the end-user problem that led to this PR? The problem was... #5786 > We should have a check in bundle doctor for the file/folder permissions in the Bundler home directory. >We should print a warning if there are any files/folders that is owned by another user but is readable/writable but prints an error when a file cannot be read or written to. ### What is your fix for the problem, implemented in this PR? Created private method ```check_home_permissions``` that will print a warning if there are any files/folders that are owned by another user but are readable/writable, and print an error when the bundler home dir contains a file cannot be read or written to ### Why did you choose this fix out of the possible options? I chose this fix because it's what was requested in the open issue. (cherry picked from commit fe9d698)

ajwann force-pushed the check-permissions-in-doctor-command branch from de96d90 to 40c73e2 Compare November 18, 2017 18:36

ajwann changed the title ~~WIP: check permissions in doctor command~~ check permissions in doctor command Nov 18, 2017

ajwann force-pushed the check-permissions-in-doctor-command branch from 0f7c518 to 12cce8e Compare November 18, 2017 19:41

ajwann commented Nov 20, 2017

View reviewed changes

segiddins requested a review from colby-swandale November 22, 2017 02:58

colby-swandale reviewed Nov 26, 2017

View reviewed changes

segiddins reviewed Nov 28, 2017

View reviewed changes

colby-swandale reviewed Dec 4, 2017

View reviewed changes

olleolleolle reviewed Dec 25, 2017

View reviewed changes

ajwann force-pushed the check-permissions-in-doctor-command branch from 2c942b8 to 8ce18f7 Compare January 14, 2018 15:50

colby-swandale reviewed Jan 14, 2018

View reviewed changes

ajwann force-pushed the check-permissions-in-doctor-command branch from bab8a62 to 65f5479 Compare January 15, 2018 15:24

colby-swandale mentioned this pull request Jan 24, 2018

Add man page for bundle doctor #6271

Merged

ajwann and others added 8 commits January 25, 2018 10:00

check Bundler.home permissions in doctor command

40911dd

use Bundler.ui.info instead of exception

0c9fb52

prefix outputted files with a - for readability

bc072d8

[CLI::Doctor] Avoid looping over all files twice

f0e5f9c

'to the current user' should be 'by the current user'

c5e1be8

readable/writable is more descriptive than read/write

6ee9f72

corrected spelling of stil to still

b1fd32c

warn user if a file is not R/W and owned by another user

2a21e5e

ajwann force-pushed the check-permissions-in-doctor-command branch from 65f5479 to 23f434b Compare January 25, 2018 15:04

wrap similar tests in context blocks

d82a9ef

ajwann force-pushed the check-permissions-in-doctor-command branch from 23f434b to d82a9ef Compare January 25, 2018 19:59

segiddins approved these changes Jan 26, 2018

View reviewed changes

bundlerbot merged commit d82a9ef into rubygems:master Jan 31, 2018

colby-swandale added this to the 1.16.2 milestone Feb 4, 2018

colby-swandale mentioned this pull request Feb 23, 2018

Feature: Check permissions on Bundler home directory in doctor command #5786

Closed

colby-swandale modified the milestones: 1.16.2, 1.17.0 Apr 4, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

check permissions in doctor command #6129

check permissions in doctor command #6129

ajwann commented Oct 29, 2017 •

edited

ajwann commented Nov 20, 2017 •

edited

ajwann Nov 20, 2017

ajwann Nov 20, 2017 •

edited

colby-swandale Nov 26, 2017

colby-swandale Nov 26, 2017

colby-swandale Nov 26, 2017

segiddins Nov 28, 2017

segiddins commented Dec 1, 2017

ajwann commented Dec 2, 2017

colby-swandale Dec 4, 2017

ajwann Dec 14, 2017 •

edited

colby-swandale Dec 20, 2017

olleolleolle left a comment

olleolleolle Dec 25, 2017

olleolleolle Dec 25, 2017

olleolleolle Dec 25, 2017

ajwann Jan 14, 2018 •

edited

olleolleolle Dec 25, 2017

ajwann commented Jan 4, 2018

segiddins commented Jan 13, 2018

ajwann commented Jan 14, 2018 •

edited

colby-swandale Jan 14, 2018

colby-swandale Jan 14, 2018

ajwann Jan 15, 2018 •

edited

ajwann commented Jan 15, 2018 •

edited

ajwann commented Jan 25, 2018 •

edited

ajwann commented Jan 25, 2018 •

edited

colby-swandale commented Jan 27, 2018

colby-swandale commented Jan 31, 2018

bundlerbot commented Jan 31, 2018

bundlerbot commented Jan 31, 2018

bundlerbot commented Jan 31, 2018

check permissions in doctor command #6129

check permissions in doctor command #6129

Conversation

ajwann commented Oct 29, 2017 • edited

What was the end-user problem that led to this PR?

What is your fix for the problem, implemented in this PR?

Why did you choose this fix out of the possible options?

ajwann commented Nov 20, 2017 • edited

Choose a reason for hiding this comment

ajwann Nov 20, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

segiddins commented Dec 1, 2017

ajwann commented Dec 2, 2017

Choose a reason for hiding this comment

ajwann Dec 14, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

olleolleolle left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ajwann Jan 14, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ajwann commented Jan 4, 2018

segiddins commented Jan 13, 2018

ajwann commented Jan 14, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ajwann Jan 15, 2018 • edited

Choose a reason for hiding this comment

ajwann commented Jan 15, 2018 • edited

ajwann commented Jan 25, 2018 • edited

ajwann commented Jan 25, 2018 • edited

colby-swandale commented Jan 27, 2018

colby-swandale commented Jan 31, 2018

bundlerbot commented Jan 31, 2018

bundlerbot commented Jan 31, 2018

bundlerbot commented Jan 31, 2018

ajwann commented Oct 29, 2017 •

edited

ajwann commented Nov 20, 2017 •

edited

ajwann Nov 20, 2017 •

edited

ajwann Dec 14, 2017 •

edited

ajwann Jan 14, 2018 •

edited

ajwann commented Jan 14, 2018 •

edited

ajwann Jan 15, 2018 •

edited

ajwann commented Jan 15, 2018 •

edited

ajwann commented Jan 25, 2018 •

edited

ajwann commented Jan 25, 2018 •

edited