Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Commit

Permalink
Merge #7478
Browse files Browse the repository at this point in the history
7478: Revert "Write & read dummy gems binarily" r=deivid-rodriguez a=deivid-rodriguez

This reverts commit f11c475.


### What was the end-user problem that led to this PR?

The problem was that since #7451, azure logs are flooded with messages like

```
The file will have its original line endings in your working directory
warning: LF will be replaced by CRLF in foo.gemspec.
```

This makes it hard to scan for other potential errors.

### What was your diagnosis of the problem?

My diagnosis was that some commit in that PR introduced this warnings.

### What is your fix for the problem, implemented in this PR?

My fix is to revert the offending commit.

Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
  • Loading branch information
bundlerbot and deivid-rodriguez committed Dec 13, 2019
2 parents 3bd06e7 + 831093c commit f143253
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion spec/install/redownload_spec.rb
Expand Up @@ -17,7 +17,7 @@
bundle! :install, flag => true

expect(out).to include "Installing rack 1.0.0"
expect(rack_lib.binread).to eq("RACK = '1.0.0'\n")
expect(rack_lib.open(&:read)).to eq("RACK = '1.0.0'\n")
expect(the_bundle).to include_gems "rack 1.0.0"
end

Expand Down
2 changes: 1 addition & 1 deletion spec/support/builders.rb
Expand Up @@ -632,7 +632,7 @@ def @spec.validate(*); end
@files.each do |file, source|
file = Pathname.new(path).join(file)
FileUtils.mkdir_p(file.dirname)
File.open(file, "wb") {|f| f.puts source }
File.open(file, "w") {|f| f.puts source }
end
@spec.files = @files.keys
path
Expand Down

0 comments on commit f143253

Please sign in to comment.