Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Commit

Permalink
Auto merge of #6306 - alyssais:gpg_test, r=colby-swandale
Browse files Browse the repository at this point in the history
Don't GPG-sign test setup commits

Running `bin/rake spec` in the Bundler repository causes a bunch of failures if `commit.gpgsign` is set in the global Git configuration.

Bundler's tests were making Git commits and trying to GPG sign them.

Set `commit.gpgsign` to `false` when initializing a Git repository in the tests.

I chose this fix because the alternative would be to pass `--no-gpg-sign` every time a commit is made in the tests, which would have a bigger maintenance impact.
  • Loading branch information
bundlerbot committed Feb 23, 2018
2 parents 3d82585 + 9f3bad4 commit c4fc79a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions spec/bundler/gem_helper_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ def remove_push_guard(gemspec_content)
`git init`
`git config user.email "you@example.com"`
`git config user.name "name"`
`git config commit.gpgsign false`
`git config push.default simple`
end

Expand Down
1 change: 1 addition & 0 deletions spec/support/builders.rb
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,7 @@ def _build(options)
`git add *`
`git config user.email "lol@wut.com"`
`git config user.name "lolwut"`
`git config commit.gpgsign false`
`git commit -m 'OMG INITIAL COMMIT'`
end
end
Expand Down

0 comments on commit c4fc79a

Please sign in to comment.