This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
7211: Use real paths for `bundle clean` r=colby-swandale a=deivid-rodriguez Fixes #7208. ### What was the end-user problem that led to this PR? The problem was that since rubygems 3.0, `bundle clean` incorrectly cleans git gems when they are installed to a symlinked location, but still being used. ### What was your diagnosis of the problem? My diagnosis was that since rubygems/rubygems#2352, `Gem.dir` returns an array of realpaths, not symlinked ones. However, we don't do the same resolution on the `bundler` side, so in this situation git gems are not correctly skipped from the cleanup. ### What is your fix for the problem, implemented in this PR? My fix is to resolve the array of paths `bundle clean` uses to do its thing into an array of real paths, just like rubygems does now. ### Why did you choose this fix out of the possible options? I chose this fix because it fixes the problem. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
- Loading branch information