Bump haml_lint from 0.40.1 to 0.41.0 #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [haml_lint](https://github.com/sds/haml-lint) from 0.40.1 to 0.41.0. - [Release notes](https://github.com/sds/haml-lint/releases) - [Changelog](https://github.com/sds/haml-lint/blob/main/CHANGELOG.md) - [Commits](sds/haml-lint@v0.40.1...v0.41.0) --- updated-dependencies: - dependency-name: haml_lint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
deivid-rodriguez
temporarily deployed
to
bundler-site-dependabot-njekl5
deivid-rodriguez
temporarily deployed
to
bundler-site-dependabot-njekl5
|
(I searched around for the problem, and I thank the existing reported Issues for being so clear! rubocop/rubocop#9864 ) HAML-Lint seems not to support all kinds of arguments. Perhaps we must make this uglier to make it pass? Update: sds/haml-lint#333 the workaround is to fully ignore I will make an attempted disable, and see if we can get the linting to pass like that. (Yes, that passed.) Since we had 1 and only 1 such linting failure, perhaps we could rephrase the HAML code locally, perhaps using local variables - that way we could re-enable the RuboCop rule and enjoy its benefits elsewhere. |
This is a workaround, to make haml-lint linting pass.
deivid-rodriguez
temporarily deployed
to
bundler-site-dependabot-njekl5
deivid-rodriguez
temporarily deployed
to
bundler-site-dependabot-njekl5
|
Locally, I was able to make it pass, by making it slightly uglier, to get it to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps haml_lint from 0.40.1 to 0.41.0.
Release notes
Sourced from haml_lint's releases.
Changelog
Sourced from haml_lint's changelog.
Commits
4f23cc3Cut version 0.41.0 (#373)919e6fdKeep newlines in extracted Ruby (#369)b338aa5Update change log (#368)d56e715Compatibility with Haml 6 (#367)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)