Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rack from 2.2.4 to 2.2.5 #1011

Merged
merged 1 commit into from Jan 1, 2023
Merged

Update rack from 2.2.4 to 2.2.5 #1011

merged 1 commit into from Jan 1, 2023

Conversation

tnir
Copy link
Collaborator

@tnir tnir commented Jan 1, 2023

See rack/rack#1998 for Ruby 3.2.0

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

What was the end-user problem that led to this PR?

Nothing. But we will encounter some problem described in rack/rack#1998 for Ruby 3.2.0 since we are already in 3.2.0 #984.

What was your diagnosis of the problem?

We cannot use rack 3.0 since middleman blocks it.

What is your fix for the problem, implemented in this PR?

Updates rack from 2.2.4 to 2.2.5.

Why did you choose this fix out of the possible options?

Maybe we can allow middleman to use rack 3.0 if we have time to contribute middleman.

See rack/rack#1998 for Ruby 3.2.0

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@tnir tnir self-assigned this Jan 1, 2023
@tnir tnir added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jan 1, 2023
@tnir tnir added this to the Re-architecturing H1 2023 milestone Jan 1, 2023
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-tn-rack-2--8c2qxw January 1, 2023 06:33 Inactive
@tnir tnir merged commit c4f06f4 into master Jan 1, 2023
@tnir tnir deleted the tn-rack-2.2.5 branch January 1, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants