Only load Railtie integration if Rails::Railtie is defined
#319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed by the [Rails documentation](https://api.rubyonrails.org/classes/Rails/Railtie.html#class-Rails::Railtie-label-Creating+a+Railtie), creating Railties should explicitly ensure that `Rails::Railtie` is defined. There could be non-rails application use-cases where `Rails` is defined, yet `Rails::Railtie` is not loaded. Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com> Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
pkuczynski
approved these changes
Jun 1, 2022
|
@cjlarose what do you think? I think we can merge it without the test... |
Merged
danilogco
pushed a commit
to dcotecnologia/confset
that referenced
this pull request
Jun 6, 2022
…onfig#319) Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed by the Rails documentation, creating Railties should explicitly ensure that
Rails::Railtieis defined.There could be non-rails application use-cases where
Railsis defined, yetRails::Railtieis not loaded.We looked into how to add a new test for this use-case but couldn't figure a simple way to load Rails without Railtie. Any idea how to do it? Or are we happy with the change without test?