Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ruby 2.7.0-preview1 to the test matrix and upgrade older versions #226

Closed
wants to merge 15 commits into from
Closed

Add Ruby 2.7.0-preview1 to the test matrix and upgrade older versions #226

wants to merge 15 commits into from

Conversation

pkuczynski
Copy link
Member

No description provided.

@pkuczynski
Copy link
Member Author

@rdubya would you like to help me with this one? I added upcoming ruby 2.7, and it's failing with error:

undefined method new_ostruct_member' for #Config::Options`

@rdubya
Copy link
Contributor

rdubya commented Jun 20, 2019

It looks like that method was deprecated in 2.4 and must have been removed in 2.7, not sure if I'll have time today but I might have time tonight to look at it

@pkuczynski
Copy link
Member Author

I have noticed that it has been deprecated and now removed, but not sure how to fix that. If you could have a look it would be great! Btw. should we already release 2.0 or wait for this one to be fixed?

@rdubya
Copy link
Contributor

rdubya commented Jun 20, 2019

Actually, it looks like method_missing might handle it by default now and the line can be removed. I pulled it out and the tests all passed on 2.4

@pkuczynski pkuczynski added this to the 2.0 milestone Jun 20, 2019
@pkuczynski pkuczynski modified the milestones: 2.0, 2.0.1 Jun 22, 2019
@codeclimate
Copy link

codeclimate bot commented Jun 22, 2019

Code Climate has analyzed commit a6b1997 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.0% (0.4% change).

View more on Code Climate.

@eitoball
Copy link

I worked on this a bit. This is my branch. This branch has successful build.

Rails 6.0 had issue in ruby 2.7, and it has been fixed in rails/rails#37504.

@pkuczynski pkuczynski modified the milestones: 2.1.0, 2.2.0 Jan 3, 2020
@pkuczynski
Copy link
Member Author

Replaced by #255 and #264

@pkuczynski pkuczynski closed this Jan 4, 2020
@pkuczynski pkuczynski deleted the upgrade-ruby-test-version branch January 4, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pkuczynski @rdubya @eitoball