Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JavaScript Regex Pattern #242

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
10 changes: 4 additions & 6 deletions lib/coderay/scanners/java_script.rb
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ class JavaScript < Scanner
add(KEYWORDS, :keyword) # :nodoc:

ESCAPE = / [bfnrtv\n\\'"] | x[a-fA-F0-9]{1,2} | [0-7]{1,3} /x # :nodoc:
UNICODE_ESCAPE = / u[a-fA-F0-9]{4} | U[a-fA-F0-9]{8} /x # :nodoc:
REGEXP_ESCAPE = / [bBdDsSwW] /x # :nodoc:
STRING_CONTENT_PATTERN = {
UNICODE_ESCAPE = / u[a-fA-F0-9]{4} | U[a-fA-F0-9]{8} /x # :nodoc:
REGEXP_ESCAPE = / [bBdDsSwW] /x # :nodoc:
STRING_CONTENT_PATTERN = {
korny marked this conversation as resolved.
Show resolved Hide resolved
korny marked this conversation as resolved.
Show resolved Hide resolved
korny marked this conversation as resolved.
Show resolved Hide resolved
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operator = should be surrounded by a single space. (https://rubystyle.guide#spaces-operators)

"'" => /[^\\']+/,
'"' => /[^\\"]+/,
'/' => /[^\\\/]+/,
'/' => %r{ (?: [^\\/\[]+ | \[ ([^\]\\]+ | \\.)* \]? )+ }mx,
} # :nodoc:
KEY_CHECK_PATTERN = {
"'" => / (?> [^\\']* (?: \\. [^\\']* )* ) ' \s* : /mx,
Expand Down Expand Up @@ -219,8 +219,6 @@ def scan_tokens encoder, options
encoder
end

protected

def reset_instance
super
@xml_scanner.reset if defined? @xml_scanner
Expand Down