Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More rubies on CI, deprecating ruby 2.3 due to test failure #68

Merged
merged 3 commits into from
Mar 20, 2021

Conversation

mathieujobin
Copy link
Contributor

ruby 2.3 now raise an ArgumentError while running tests

 ........E
===============================================================================
Error: test_slow_connect(TestWEBrickSSLServer): ArgumentError: wrong number of arguments (given 3, expected 1..2)
/opt/hostedtoolcache/Ruby/2.3.8/x64/lib/ruby/2.3.0/timeout.rb:73:in `timeout'
/home/runner/work/webrick/webrick/test/lib/envutil.rb:72:in `timeout'
/home/runner/work/webrick/webrick/test/webrick/test_ssl_server.rb:58:in `test_slow_connect'
     55:       :SSLEnable => true,
     56:       :SSLCertName => "/C=JP/O=www.ruby-lang.org/CN=Ruby",
     57:     }
  => 58:     EnvUtil.timeout(10) do
     59:       TestWEBrick.start_server(Echo, config) do |server, addr, port, log|
     60:         outer = TCPSocket.new(addr, port)
     61:         inner = TCPSocket.new(addr, port)
===============================================================================

making 2.4 the minimum and including 3.0 as base ruby

there is an argument error with 2.3

 ........E
===============================================================================
Error: test_slow_connect(TestWEBrickSSLServer): ArgumentError: wrong number of arguments (given 3, expected 1..2)
/opt/hostedtoolcache/Ruby/2.3.8/x64/lib/ruby/2.3.0/timeout.rb:73:in `timeout'
/home/runner/work/webrick/webrick/test/lib/envutil.rb:72:in `timeout'
/home/runner/work/webrick/webrick/test/webrick/test_ssl_server.rb:58:in `test_slow_connect'
     55:       :SSLEnable => true,
     56:       :SSLCertName => "/C=JP/O=www.ruby-lang.org/CN=Ruby",
     57:     }
  => 58:     EnvUtil.timeout(10) do
     59:       TestWEBrick.start_server(Echo, config) do |server, addr, port, log|
     60:         outer = TCPSocket.new(addr, port)
     61:         inner = TCPSocket.new(addr, port)
===============================================================================
@hsbt hsbt merged commit d63a107 into ruby:master Mar 20, 2021
@hsbt
Copy link
Member

hsbt commented Mar 20, 2021

👍

@mathieujobin mathieujobin deleted the more-rubies branch March 21, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants