Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for macos-14 GitHub runners #567

Merged
merged 3 commits into from Jan 31, 2024
Merged

Add support for macos-14 GitHub runners #567

merged 3 commits into from Jan 31, 2024

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Jan 30, 2024 •
edited

@mbibosch
Copy link

mbibosch commented Jan 30, 2024 •
edited

Thank you for this proposal. It looks fine to me but probably getDownloadURL needs to be revisited as well, see here

@mbibosch mbibosch mentioned this pull request Jan 30, 2024
Closed
2 tasks
@ntkme
Copy link
Contributor Author

ntkme commented Jan 30, 2024

Thank you for this proposal. It looks fine to me but probably getDownloadURL needs to be revisited as well, see here

That is actually correct. It is the platform of the ruby ci used builds the binary release.

@ntkme ntkme changed the title Add support for macos-14-arm64 GitHub runners Add support for macos-14 GitHub runners Jan 30, 2024
LaStrada
LaStrada reviewed Jan 31, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@ntkme
Copy link
Contributor Author

ntkme commented Jan 31, 2024

We can probably remove the usage of self-hosted macos-arm-oss and rely on macos-14 (arm64) for CI, but I've kept it for now.

eregon
eregon approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks great.
I'll let the CI run and then merge.

.github/workflows/test.yml
@@ -33,6 +33,14 @@ jobs:
exclude:
# https://github.com/ruby/setup-ruby/issues/496
- { os: ubuntu-22.04, ruby: '2.2' }
# Too old, fails to compile on macos-14 (arm64)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fails to compile? Do you have an example error?
Since we're not compiling these Rubies on macos-14 do you mean C extensions fail to compile?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah it's just the same as # Too old, fails to compile on macos-arm-oss below, I'll tweak the comment post-merge

@eregon eregon mentioned this pull request Jan 31, 2024
Closed
@eregon
Copy link
Member

eregon commented Jan 31, 2024

We can probably remove the usage of self-hosted macos-arm-oss and rely on macos-14 (arm64) for CI, but I've kept it for now.

It's not self-hosted but macos arm runners provided by GitHub for the Ruby org.
Looking at it, macos-arm-oss is macOS 13.6.3 while macos-14 is macOS 14.2.1.
We need to keep building on macOS 13 to support these: https://docs.github.com/en/actions/using-github-hosted-runners/about-larger-runners/about-larger-runners#about-macos-larger-runners

@eregon eregon merged commit 98f8f7e into ruby:master Jan 31, 2024
183 checks passed
@ntkme ntkme deleted the macos-14-arm64 branch January 31, 2024 16:30
yolanv pushed a commit to Ordina-Group/JWorks-blog that referenced this pull request Feb 12, 2024
@renovate
chore(deps): update ruby/setup-ruby action to v1.171.0 (#2)
f318438 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [ruby/setup-ruby](https://togithub.com/ruby/setup-ruby) | action |
minor | `v1.167.0` -> `v1.171.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>ruby/setup-ruby (ruby/setup-ruby)</summary>

###
[`v1.171.0`](https://togithub.com/ruby/setup-ruby/releases/tag/v1.171.0):
Add support for macos-14 GitHub runners

[Compare
Source](https://togithub.com/ruby/setup-ruby/compare/v1.170.0...v1.171.0)

#### What's Changed

- Update url to supported by
[@&#8203;LaStrada](https://togithub.com/LaStrada) in
[ruby/setup-ruby#569
- Add support for macos-14 GitHub runners by
[@&#8203;ntkme](https://togithub.com/ntkme) in
[ruby/setup-ruby#567

#### New Contributors

- [@&#8203;LaStrada](https://togithub.com/LaStrada) made their first
contribution in
[ruby/setup-ruby#569
- [@&#8203;ntkme](https://togithub.com/ntkme) made their first
contribution in
[ruby/setup-ruby#567

**Full Changelog**:
ruby/setup-ruby@v1.170.0...v1.171.0

###
[`v1.170.0`](https://togithub.com/ruby/setup-ruby/releases/tag/v1.170.0):
Add CRuby 3.2.3 on Windows

[Compare
Source](https://togithub.com/ruby/setup-ruby/compare/v1.169.0...v1.170.0)

#### What's Changed

- Update CRuby releases on Windows by
[@&#8203;ruby-builder-bot](https://togithub.com/ruby-builder-bot) in
[ruby/setup-ruby#566

**Full Changelog**:
ruby/setup-ruby@v1.169.0...v1.170.0

###
[`v1.169.0`](https://togithub.com/ruby/setup-ruby/releases/tag/v1.169.0):
Add windows-toolchain input

[Compare
Source](https://togithub.com/ruby/setup-ruby/compare/v1.168.0...v1.169.0)

#### What's Changed

- Add windows-toolchain input by
[@&#8203;MSP-Greg](https://togithub.com/MSP-Greg) in
[ruby/setup-ruby#563

**Full Changelog**:
ruby/setup-ruby@v1.168.0...v1.169.0

###
[`v1.168.0`](https://togithub.com/ruby/setup-ruby/releases/tag/v1.168.0):
Add ruby-3.2.3

[Compare
Source](https://togithub.com/ruby/setup-ruby/compare/v1.167.0...v1.168.0)

#### What's Changed

- Add ruby-3.2.3 by
[@&#8203;ruby-builder-bot](https://togithub.com/ruby-builder-bot) in
[ruby/setup-ruby#565

**Full Changelog**:
ruby/setup-ruby@v1.167.0...v1.168.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am
every weekday,every weekend" in timezone Europe/Brussels, Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Ordina-Group/ordina-jworks.github.io).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoic291cmNlIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
robbkidd added a commit to robbkidd/opentelemetry-ruby that referenced this pull request May 8, 2024
@robbkidd
chore: bump ruby/setup-ruby from 1.165.1 to 1.176.0
4ccf399 
To fix an error[1] on macos runners resolved in v1.171.0[2]:

    The current runner (macos-14-arm64) was detected as self-hosted
    because the platform does not match a GitHub-hosted runner image
    (or that imageis deprecated and no longer supported).

[1] ruby/setup-ruby#568
[2] ruby/setup-ruby#567
@robbkidd robbkidd mentioned this pull request May 8, 2024
Merged
robbkidd added a commit to robbkidd/opentelemetry-ruby that referenced this pull request May 8, 2024
@robbkidd
chore: bump ruby/setup-ruby from 1.165.1 to 1.171.0
78df761 
To fix an error[1] on macos runners resolved in v1.171.0[2]:

    The current runner (macos-14-arm64) was detected as self-hosted
    because the platform does not match a GitHub-hosted runner image
    (or that imageis deprecated and no longer supported).

[1] ruby/setup-ruby#568
[2] ruby/setup-ruby#567
robertlaurin pushed a commit to open-telemetry/opentelemetry-ruby that referenced this pull request May 8, 2024
@robbkidd
chore: bump ruby/setup-ruby from 1.165.1 to 1.176.0 (#1635)
7162e34 
* chore: bump ruby/setup-ruby from 1.165.1 to 1.176.0

To fix an error[1] on macos runners resolved in v1.171.0[2]:

    The current runner (macos-14-arm64) was detected as self-hosted
    because the platform does not match a GitHub-hosted runner image
    (or that imageis deprecated and no longer supported).

[1] ruby/setup-ruby#568
[2] ruby/setup-ruby#567

* resolve missing constant error in Ruby 3.3.1
@github-actions github-actions bot mentioned this pull request May 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

@LaStrada LaStrada LaStrada left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macos-14-arm64 detected as self-hosted
4 participants
@ntkme @mbibosch @eregon @LaStrada