Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actions/checkout@v3 #302

Closed
wants to merge 1 commit into from

Conversation

kaiquekandykoga
Copy link

No description provided.

@eregon
Copy link
Member

eregon commented Mar 31, 2022

What's the advantage of v3? I don't find much on https://github.com/actions/checkout.
It seems a node version update, why should this action care about that? (this action uses node12 BTW)
And should the documentation be updated too?

@kaiquekandykoga
Copy link
Author

I was just trying to keep it up to date. I changed only the workflows, because I have tested only the workflow in my fork and not the examples in the documentation (README.md).

I am closing it.

@eregon
Copy link
Member

eregon commented Mar 31, 2022

Thank you for the PR, we may end up merging it.
I really question the need of a new major version of actions/checkout just to bump the node version though, that seems needlessly annoying for the majority of workflows (actions/checkout#708 (comment)).

@kaiquekandykoga
Copy link
Author

I understand. Next time I will bring better arguments for changes like that.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants