thread_pthread: Grow main_stack if required (fixes tests on HPPA) #7676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesamesam
force-pushed
the
hppa-pthreads
branch
3 times, most recently
from
3ebe81f
to
6af7947
Compare
On HPPA, test_insns.rb fails (along with various Ruby gems) with 'stack level too deep (SystemStackError)'. This turns out to be because HPPA defaults to a small(er) stack. With this change, most of Ruby's test suite now passes on HPPA. Thanks to both Dave and Helge for the investigation and coming up with the patch. Bug: https://bugs.gentoo.org/701494 Bug: https://bugs.debian.org/881773 Bug: https://bugs.debian.org/881772 (for PPC64) Bug: rack/rack#1640 Thanks-to: John David Anglin <dave.anglin@bell.net> Thanks-to: Helge Deller <deller@gmx.de> Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
force-pushed
the
hppa-pthreads
branch
from
6af7947
to
9d04c14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On HPPA, test_insns.rb fails (along with various Ruby gems) with 'stack level too deep (SystemStackError)'. This turns out to be because HPPA defaults to a small(er) stack.
With this change, Ruby's test suite passes on HPPA.
Thanks to both Dave and Helge for the investigation and coming up with the patch.
Bug: https://bugs.gentoo.org/701494
Bug: https://bugs.debian.org/881773
Bug: https://bugs.debian.org/881772 (for PPC64)
Bug: rack/rack#1640
Thanks-to: John David Anglin dave.anglin@bell.net
Thanks-to: Helge Deller deller@gmx.de