Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial compliance with doc/method_documentation.rdoc in string.c #3436

Merged
merged 1 commit into from Aug 20, 2020
Merged

Partial compliance with doc/method_documentation.rdoc in string.c #3436

merged 1 commit into from Aug 20, 2020

Conversation

BurdetteLamar
Copy link
Member

Removes references to *-convertible thingies.

@BurdetteLamar BurdetteLamar added the Documentation Improvements to documentation. label Aug 20, 2020
@BurdetteLamar
Copy link
Member Author

@jeremyevans, I've put up a PR over at flori/json: flori/json#446

I can't request a review there (button not displayed). Do you have heft over there?

jeremyevans
jeremyevans approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. I don't have any access to flori/json.

@BurdetteLamar BurdetteLamar merged commit 5152555 into ruby:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyevans jeremyevans jeremyevans approved these changes

Assignees
No one assigned
Labels
Documentation Improvements to documentation.
Milestone
No milestone
2 participants
@BurdetteLamar @jeremyevans