Change Reline::ANSI to a general io #659
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
force-pushed
the
ansi_is_general_io
branch
2 times, most recently
from
d5d4994
to
bd69658
Compare
tompng
force-pushed
the
ansi_is_general_io
branch
3 times, most recently
from
baa398f
to
cb72da1
Compare
Reline::ANSI has a partial non-tty supporting code. It should be a general io. Reline::GeneralIO should be renamed because it is actually not a general io but an unusable io only for test usage.
tompng
force-pushed
the
ansi_is_general_io
branch
from
cb72da1
to
2779c89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #537, #616 and #690, the behavior will be more similar to Readline's behavior.
Reline::ANSIalready partially supports non-tty env, but not fully.Reline::GeneralIOis a completely unusable IOGate which is only used for testing. The implementation is not a general io.This pull request changes
Reline::ANSIto a general io that supports both tty and non-tty environment.Reline::GeneralIOwill be renamed toReline::TestDumbIObecause it is not a GeneralIO, it is not a DumbIO. It is not optimized for dumb terminal, just outputs ascii characters with unusable repetition.