Improve performance of Reline::Unicode.get_mbchar_width
#632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance and Regression check
Tested with this benchmark
Result with yjit
Result without yjit
Implementation
Uses
bsearch_index
. Time complexity of bsearch_index is O(log(N)), N is total count of unicode characters.We can also choose less-memory O(1) lookup (shallow tree with bignum, https://gist.github.com/tompng/6be795d487e1a0105ada41e24f9528c4) but the generated file will be unreadable.
I think this bsearch_index is a good choice because:
unicode.rb
code simplicity, and readability of generatedeast_asian_width.rb
are goodBug fixes
Fixed these two type of chars. these are excluded from the performance/regression benchmark.
Nonspacing Mark
Reline returned 0 for
/\p{M}/
(Mark). I think it was a mistake of/\p{Mn}/
(Nonspacing Mark).Three Em Dash
Reline returned 3 for three em dash
"\u2e3b"
.Reline returned 1 for two em dash
"\u2e3a"
.It's defined as N(Neutral) and shuold be 1. Terminal.app, VSCode, iTerm, Alacrytty uses width=1 (but overflows because font is very wide)