Change Reline::ANSI to a general io #659
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #537, #616 and #690, the behavior will be more similar to Readline's behavior.
Reline::ANSI
already partially supports non-tty env, but not fully.Reline::GeneralIO
is a completely unusable IOGate which is only used for testing. The implementation is not a general io.This pull request changes
Reline::ANSI
to a general io that supports both tty and non-tty environment.Reline::GeneralIO
will be renamed toReline::TestDumbIO
because it is not a GeneralIO, it is not a DumbIO. It is not optimized for dumb terminal, just outputs ascii characters with unusable repetition.