Fix ri completion to always return candidates start with a given name #1082

tompng · 2024-01-12T15:19:53Z

Fixes https://bugs.ruby-lang.org/issues/20171

RDoc has a test code like this

assert_equal %w[Foo#Bar  Foo::bar], @driver.complete('Foo.')

Reline doesn't accept this completion list because it does not start from 'Foo.'

To make it work with Reline, completion_proc should always return a list of string that starts with the given completion_target text.

This will also fix this weird behavior in Ruby 3.2 using readline

>> Array.t[TAB]
↓
>> Array
(tab complete deletes text)

st0012 · 2024-01-12T19:32:45Z

lib/rdoc/ri/driver.rb

@@ -744,7 +744,7 @@ def complete name
    complete_klass  name, klass, selector, method, completions
    complete_method name, klass, selector,         completions

-    completions.sort.uniq
+    completions.sort.uniq.select {|s| s.start_with? name }


Just a suggestion: maybe call .sort last would be slightly more efficient given the list size being smaller?

st0012 reviewed Jan 12, 2024

View reviewed changes

Fix ri completion to always return candidates start with a given name

acaf13d

tompng force-pushed the reline_readline_completion_fix branch from df945bc to acaf13d Compare January 21, 2024 16:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix ri completion to always return candidates start with a given name #1082

Fix ri completion to always return candidates start with a given name #1082

tompng commented Jan 12, 2024 •

edited

st0012 Jan 12, 2024

Fix ri completion to always return candidates start with a given name #1082

Are you sure you want to change the base?

Fix ri completion to always return candidates start with a given name #1082

Conversation

tompng commented Jan 12, 2024 • edited

st0012 Jan 12, 2024

Choose a reason for hiding this comment

tompng commented Jan 12, 2024 •

edited