Fixed infinite loop with CR #339

ruby · Jan 12, 2015 · 811c86f · 811c86f
1 parent 01c805c
commit 811c86f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/History.rdoc b/History.rdoc
@@ -1,3 +1,8 @@
+=== 4.2.1
+
+* Bug fixes
+  * Fixed infinite loop with CR #339
+
 === 4.2.0 / 2014-12-06
 
 * Major enhancements

diff --git a/lib/rdoc/text.rb b/lib/rdoc/text.rb
@@ -68,11 +68,11 @@ def expand_tabs text
     expanded = []
 
     text.each_line do |line|
-      line.gsub!(/^((?:.{8})*?)([^\t\r\n]{0,7})\t/) do
+      nil while line.gsub!(/(?:\G|\r)((?:.{8})*?)([^\t\r\n]{0,7})\t/) do
         r = "#{$1}#{$2}#{' ' * (8 - $2.size)}"
         r.force_encoding text.encoding if Object.const_defined? :Encoding
         r
-      end until line !~ /\t/
+      end
 
       expanded << line
     end

diff --git a/test/test_rdoc_text.rb b/test/test_rdoc_text.rb
@@ -56,6 +56,9 @@ def test_expand_tabs
 
     assert_equal('.               .',
                  expand_tabs(".\t\t."), 'dot tab tab dot')
+
+    assert_equal('a       a',
+                 Timeout.timeout(1) {expand_tabs("\ra\ta")}, "carriage return")
   end
 
   def test_expand_tabs_encoding