Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking change of execution order on TestTask #368

Merged
merged 1 commit into from Dec 21, 2020

Commits on Dec 20, 2020

  1. Fix breaking change of execution order on TestTask

    Due to ruby#357, execution order on Rake 13.0.2 changes from Rake 13.0.1.
    
    Example:
    ```
    Rake::TestTask do |t|
      t.test_files = [
        "test/a.rb",
        "test/b.rb",
      ]
    end
    ```
    
    On 13.0.2, Rake executes test/b.rb before test/a.rb because test/a.rb are loaded before rake_test_loader.rb.
    rake_test_loader.rb executes the Ruby code in ARGV using Kernel.#require, but does not execute test/a.rb which is already loaded.
    
    In addition, Rake 13.0.1 allows specifying test_files without .rb but 13.0.2 doesn't allows.
    This commit also fixes this problem.
    ```
    Rake::TestTask do |t|
      t.test_files = [
        "test/setup",
        "test/a.rb",
      ]
    end
    ```
    ysakasin committed Dec 20, 2020
    Copy the full SHA
    37635e6 View commit details
    Browse the repository at this point in the history