Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "test-unit-ruby-core" development dependency #227

Closed
wants to merge 2 commits into from

Conversation

voxik
Copy link

@voxik voxik commented Jul 19, 2023

Apart from properly specifying gem dependencies, this also allows to see on rubygems.org that there actually is some user of test-unit-ruby-core gem.

Maybe the Gemfile should also use the gemspec directive.

@hsbt
Copy link
Member

hsbt commented Aug 3, 2023

Maybe the Gemfile should also use the gemspec directive.

Can you update with that?

Properly specify gem dependencies
This allows broader eccosystem to benefit from the dependencies, such as
rubygems.org will properly report, that there is some library using
"test-unit-ruby-core".
@voxik
Copy link
Author

voxik commented Aug 4, 2023

I have tried.

However, I am not clear how #229 is supposed to work, because I have precisely zero knowledge about dependabot. Maybe I should have left the group :development in the Gemfile? I certainly don't think that having so restricted dependencies is good idea, especially I don't think that they should go into .gemspec. But I'm not sure how Bundler would handle the group together with the .gesmpec definition 🤷‍♂️

@hsbt
Copy link
Member

hsbt commented Aug 4, 2023

However, I am not clear how #229 is supposed to work, because I have precisely zero knowledge about dependabot.

Ah, sorry. dependabot is not support add_development_dependency. We can not migrate them if we rely to dependabot.

@flavorjones
Copy link
Collaborator

I certainly don't think that having so restricted dependencies is good idea

Development dependencies are only relevant for the people who are working on (or repackaging) racc, not for end users. Restricting the versions of these gems is an acceptable practice.

properly specifying gem dependencies

The Gemfile is an acceptable and proper place to specify development dependencies. I think it is completely appropriate for us to declare them where and how it's convenient and sustainable for us.

I have precisely zero knowledge about dependabot

Dependabot is a tool that helps open source maintainers ensure that a) dependencies are updated when new versions are available, b) and that CI still passes with those updated dependencies. Particularly for maintainers of many gems, this automation is very valuable for avoiding bitrot.

@voxik I'm not sure what outcome you want from this change. test-unit-ruby-core is already declared in the Gemfile. Help me understand?

@voxik
Copy link
Author

voxik commented Aug 4, 2023

@voxik I'm not sure what outcome you want from this change. test-unit-ruby-core is already declared in the Gemfile. Help me understand?

I was wondering, why would somebody want to introduce test-unit-ruby-core into Fedora. I thought that the most convenient way would be to take look at rubygems.org:

https://rubygems.org/gems/test-unit-ruby-core/reverse_dependencies

But this page says nothing.

Also, generally, locking development dependencies might make upstream life easier, but it does downstream (such as Fedora) life harder. I am quite sure that the test suite can be tuned to work with specific versions, but we don't necessarily have them downstream.

@hsbt
Copy link
Member

hsbt commented Oct 28, 2023

We should keep to use Gemfile, not gemspec.

@hsbt hsbt closed this Oct 28, 2023
@voxik
Copy link
Author

voxik commented Oct 28, 2023

We should keep to use Gemfile, not gemspec.

Specifically for this reason, there were two commits. I wish you have accepted at least the "Add "test-unit-ruby-core" development dependency" commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants