Add tests for sample dir and tweak samples #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samples are tweaked - not to raise "TypeError: scan() yielded String (must be Array[2])" - allow both script usage and lib usage by adding $0 check
|
I fixed the CI failure by adding |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
racc has samples. It's very nice for begineers. But some do not work with the latest ruby;
TypeError: scan() yielded String (must be Array[2])occurs. I fixed it by adding[]onarray2.yandhash.y.Tests are added to make sure samples are working. For better testability,
$0check is added tocalc.y.