Aliases for Ripper Translation #2423
Conversation
| @@ -220,7 +220,7 @@ module Prism | |||
| source, filepath = read_source(argv) | |||
|
|
|||
| ripper = Ripper.sexp_raw(source) | |||
| prism = Prism::RipperCompat.sexp_raw(source) | |||
| prism = Prism::Translation::Ripper.sexp_raw(source) rescue :parse_error | |||
There was a problem hiding this comment.
Can we specifically rescue NotImplementedError (I'm assuming that's what your handling)? I wouldn't want this to hide a different problem.
| prism = Prism::Translation::Ripper.sexp_raw(source) rescue :parse_error | |
| prism = | |
| begin | |
| Prism::Translation::Ripper.sexp_raw(source) | |
| rescue NotImplementedError | |
| :parse_error | |
| end |
There was a problem hiding this comment.
I mostly use it to make sure that if something's not working yet in Translation::Ripper that I still see CRuby's Ripper output. When it says "parse_error" that should only hide another problem if I'm expecting a parse error. But if I'm midway through making a modification and it might get an error, this means that "prism ripper" is still useful. I guess I could add a mode that doesn't actually use Prism's Ripper and just prints out CRuby's output without trying Prism?
There was a problem hiding this comment.
Ahh that's fine. We can keep it for now, I just want this to go away eventually.
| # no block call. It can be hard to tell which of multiple equivalent | ||
| # structures it will produce. This method attempts to return a normalized | ||
| # comparable structure. | ||
| def normalized_sexp(parsed) |
There was a problem hiding this comment.
I'm fine having this for now, but we'll definitely want to get rid of this before we close this ticket out.
There was a problem hiding this comment.
I'll definitely try. I'm having trouble figuring out when Ripper does and doesn't emit this, even looking through parse.y.
noahgibbs
force-pushed
the
ripper_compat_equiv_testing
branch
from
c77bd8a
to
09537d7
Compare
|
Found a minor TruffleRuby Ripper incompatibility. Turning off that test on Truffle, filed a bug: oracle/truffleruby#3457 |
noahgibbs
force-pushed
the
ripper_compat_equiv_testing
branch
5 times, most recently
from
1fcfb88
to
e2ae276
Compare
|
Turning off the command line test on Windows. Aside from issues like not being able to just run bin/prism (need "ruby bin/prism" or rough equivalent) there's also not a great "which" equivalent. |
noahgibbs
force-pushed
the
ripper_compat_equiv_testing
branch
from
e2ae276
to
cfd4f28
Compare
|
Yeah, I'm just removing the command line test. That's annoying, I wanted to add it because the utility broke. But I'm not figuring out how to locate bin/prism to run it reliably, even if I exclude Windows. I can find it in dev checkouts (__dir__ + ../../bin/prism) and in installed gems ( |
| @@ -220,7 +220,7 @@ module Prism | |||
| source, filepath = read_source(argv) | |||
|
|
|||
| ripper = Ripper.sexp_raw(source) | |||
| prism = Prism::RipperCompat.sexp_raw(source) | |||
| prism = Prism::Translation::Ripper.sexp_raw(source) rescue :parse_error | |||
There was a problem hiding this comment.
Ahh that's fine. We can keep it for now, I just want this to go away eventually.
Handle more aliases, including fully handling aliases.txt.
As part of handling more aliases, handle symbols that are keywords, constants or operations. Handle interpolated symbols. Handle global variable references.
Better testing of prism ripper CLI and a test for it. I had broken it in renaming Translation::Ripper. Now it's tested.It also prints better output when Prism or Ripper Translation gets an exception during parsing.