Add to_text for PKCS7 and Timestamp::Response #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhenium
reviewed
May 5, 2024
|
I think it may be worth adding |
segiddins
force-pushed
the
segiddins/add-to_text-for-pkcs7-and-timestamp-response
branch
from
8772c56
to
71cd1e3
Compare
rhenium
approved these changes
May 8, 2024
|
Failure on windows/ruby 3.0-3.2 is irrelevant. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added these while trying to debug why my timestamp usage was failing, figured someone else might find them useful as well