Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssl: support IO-like object as the underlying transport #736

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

ssl: support IO-like object as the underlying transport #736

wants to merge 7 commits into from

Commits on Mar 23, 2024

  1. bio: add a BIO method that wraps IO-like object 

    Implement a minimum BIO_METHOD required for SSL/TLS. The underlying
IO-like object must implement the following methods:

 - #read_nonblock(len, exception: false)
 - #write_nonblock(str, exception: false)
 - #flush

The IO-like object is also required to implement several other methods
to function in a later commit in this series.
    @rhenium
    rhenium committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    cd12c60 View commit details
    Browse the repository at this point in the history

  2. ssl: remove unnecessary GetOpenFile() check in SSLSocket#syswrite* 

    This is no longer necessary as of commit 22e601a ("Remove usage of
IO internals. (ruby#627)", 2023-05-29).
    @rhenium
    rhenium committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    41661db View commit details
    Browse the repository at this point in the history

  3. ssl: allow underlying socket to not implement #remote_address 

    The result value is only used for generating an informative error
message. Let's just say "unsupported" if it's not available.
    @rhenium
    rhenium committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    1eb4b57 View commit details
    Browse the repository at this point in the history

  4. ssl: allow underlying socket to not implement #sync 

    The value is used to determine whether SSLSocket should skip buffering
in OpenSSL::Buffering or not. Defaulting to true (no buffering) should
be a safe option.
    @rhenium
    rhenium committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    2a83105 View commit details
    Browse the repository at this point in the history

  5. ssl: support IO-like object as the underlying transport 

    OpenSSL::SSL::SSLSocket currently requires a real IO (socket) object
because it passes the file descriptor to OpenSSL.

OpenSSL internally uses an I/O abstraction layer called BIO to interact
with the underlying socket. BIO is pluggable; the implementation can be
provided by a user application. It's possible to implement our own BIO
implementation ("BIO method") that wraps any Ruby IO-like object.

Let's do it. This allows establishing a TLS connection on top of another
TLS connection.

For the performance reason, this patch continues to use the original
socket BIO if the user passes a real IO object.
    @rhenium
    rhenium committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    ef6508f View commit details
    Browse the repository at this point in the history

  6. ham

    @rhenium
    rhenium committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    d725420 View commit details
    Browse the repository at this point in the history

  7. libressl

    @rhenium
    rhenium committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    ded7cb0 View commit details
    Browse the repository at this point in the history