Windows Ruby 3.3: Workaround: Set OPENSSL_MODULES to find providers. #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a workaround to avoid the following test failures by loading
legacy provider.
```
2) Error: test_openssl_legacy_provider(OpenSSL::TestProvider): OpenSSL::Provider::ProviderError: Failed to load legacy provider: (null) (name=legacy)
D:/a/ruby-openssl/ruby-openssl/test/openssl/test_provider.rb:62:in `load'
D:/a/ruby-openssl/ruby-openssl/test/openssl/test_provider.rb:62:in `<main>'
D:/a/ruby-openssl/ruby-openssl/test/openssl/test_provider.rb:61:in `with_openssl'
D:/a/ruby-openssl/ruby-openssl/test/openssl/test_provider.rb:36:in `test_openssl_legacy_provider'
33: end
34:
35: def test_openssl_legacy_provider
=> 36: with_openssl(<<-'end;')
37: OpenSSL::Provider.load("legacy")
38: algo = "RC4"
39: data = "a" * 1000
```
|
The CI is green. Let me merge this PR to make the CI green immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a workaround to pass the following failing tests addressed on #711. So, this PR technically fixes #711. The issue is that OpenSSL couldn't find the
lib\ossl-modules\legacy.dll. The openssl/openssl#19368 was helpful to understand teh issue and find the solution.This commit is a workaround to avoid the following test failures by loading legacy provider.
I hope this logic is included in an Ruby installer used in GitHub Actions Windows cases.
By the way, I found