Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use X509_ALGOR_get0() accessor for X509_ALGOR #687

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

botovq
Copy link
Contributor

@botovq botovq commented Oct 19, 2023

While the struct is currently still public in OpenSSL, there has been an accessor since OpenSSL 0.9.8h. It would be nice if this accessor could be used so that the struct can be made opaque at some point in the future.

While the struct is currently still public in OpenSSL, there has been
an accessor since OpenSSL 0.9.8h. It would be nice if this accessor
could be used so that the struct can be made opaque at some point in
the future.
@botovq
Copy link
Contributor Author

botovq commented Oct 19, 2023

Of course there had to be a const change in the OpenSSL 1.1 cycle. I should have thought of that. Sorry about hat. Presumably this means that we need a define that is const for OpenSSL >= 1.1 and empty otherwise. This is becoming more cumbersome than I'd hoped it to be...

@botovq botovq changed the title Use X509_ALGOR_get0() accessor for X509_ALGOR WIP: Use X509_ALGOR_get0() accessor for X509_ALGOR Oct 19, 2023
@rhenium
Copy link
Member

rhenium commented Oct 25, 2023

Makes sense to me.

I'm hoping to remove OpenSSL 1.0.2 support in our next release as the last significant user of it (RHEL 7 - on which we still test Ruby on rubyci.org) will reach EOL next year. Since this is not urgent, let's merge it after that.

@botovq
Copy link
Contributor Author

botovq commented Oct 25, 2023 via email

@botovq botovq changed the title WIP: Use X509_ALGOR_get0() accessor for X509_ALGOR Use X509_ALGOR_get0() accessor for X509_ALGOR Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants