CI: Enable the verbose mode in the mkmf.rb by env MAKEFLAGS. #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a832f5c. Because there is a simpler way to enable the verbose mode by setting the environment variable `MAKEFLAGS`.
Enable the verbose option (variable `V`) in the `Makefile` generated by `mkmf.rb` to print the compiling commands in the process of the `rake compile` by setting the environment variable `MAKEFLAGS`[1] reserved by `make`. Because it's helpful to see what compiler warnings are checked. It seems that this implementation to enable the verbose mode only works in Linux and macOS. Not Windows. [1] https://www.gnu.org/software/make/manual/html_node/Variables_002fRecursion.html
junaruga
force-pushed
the
wip/enable-mkmf-verbose-env
branch
from
8011e2d
to
08e1981
Compare
junaruga
changed the title
|
By the way, this technique is used in the mysql2 gem project too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes 2 commits, the commit reverting the #623, and a commit to enable the verbose mode in much simpler way.
Enable the verbose option (variable
V) in theMakefilegenerated bymkmf.rbto print the compiling commands in the process of therake compileby setting the environment variable
MAKEFLAGS[1] reserved bymake. Becauseit's helpful to see what compiler warnings are checked.
It seems that this implementation to enable the verbose mode only works in
Linux and macOS. Not Windows.
[1] https://www.gnu.org/software/make/manual/html_node/Variables_002fRecursion.html