Fallback to non-colored inspect when coloring takes too long #759
+53
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspecting large objects may take a long time since IRB colors the entire output of #inspect all at once. This patch lets IRB to give up coloring after a certain time and fall back to non-colored output. Changes can be observed by inspecting large Arrays, for example `[1] * 1000000`. The default timeout is 2 seconds, but this can be configured through `IRB.conf[:INSPECT_COLORING_TIMEOUT]`. Passing nil to this option will disable timeouts (IRB will never fall back to non-colored output).
|
Thanks for the PR 👍 Maybe we should improve colour printer instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspecting large objects may take a long time since IRB colors the entire output of #inspect all at once.
This patch lets IRB to give up coloring after a certain time and fall back to non-colored output.
Changes can be observed by inspecting large Arrays, for example
[1] * 1000000.The default timeout is 2 seconds, but this can be configured through
IRB.conf[:INSPECT_COLORING_TIMEOUT].Passing nil to this option will disable timeouts (IRB will never fall back to non-colored output).