Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ntop: Measure address size in bytes #61

Merged
merged 1 commit into from
Dec 23, 2023
Merged

ntop: Measure address size in bytes #61

merged 1 commit into from
Dec 23, 2023

Commits on Nov 28, 2023

  1. ntop: Measure address size in bytes 

    `IPAddr.ntop` takes the binary representation of an IP address, whose
length should be 4 or 16 *bytes* (not characters/codepoints).

The current implementation accepts strings in any encoding, but for
some values in non-BINARY encoding, it fails proper length check and
raises an `AddressFamilyError`. Since passing strings in a multibyte
encoding has never worked correctly for years, this patch makes it an
explicit error with an `InvalidAddressError`.

Fixes: ruby#56
    @hanazuki
    hanazuki committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    a33fd14 View commit details
    Browse the repository at this point in the history