Commits on Sep 15, 2020

1. Add IPAddr#unmasked …

   Prior to this commit there was no way to retrieve the unmasked address
   for an `IPAddr`. For example, given the `IPAddr` below there is no
   method or instance variable that would return `"1.2.3.4"`.
   
   ```rb
   IPAddr.new("1.2.3.4/8")
   ```
   
   This poses a problem for Rails in supporting the PostgreSQL inet type.
   Rails uses `IPAddr` for both the cidr and inet types, but at the moment
   cannot fully support the inet type, which "accepts values with nonzero
   bits to the right of the netmask". This came up originally in
   rails/rails#14857, and more recently in
   rails/rails#40138. The change in this commit
   would allow us to support the inet type without moving to another
   library.
   
   This commit holds onto the address before the mask is applied, in a new
   instance variable `@unmasked_addr`. It then exposes this via
   `unmasked`.
   
   This was originally implemented back in
   ruby/ruby#599, but it got stale and was
   eventually closed. There are also a few differences with that PR:
   
   - That PR set up the instance variable inside of `mask!`, which meant
     that the new method was broken in the case of an `IPAddr` with no
     mask.
   - That PR introduced a method that returned a `to_s`-like value, whereas
     this one returns a new, unmasked IPAddr object.
   - As a result of the above, this version doesn't need to change the
     signature of `to_s`
   - This PR also sets @unmasked_addr within `set`, which covers a few
     additional edge cases with non-string arguments and with methods like
     `&` or `succ` that clone the IpAdrr and call `set`
   
   Co-authored-by: Jarek Radosz <jradosz@gmail.com>

   

   composerinteralia and CvX committed Sep 15, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for d5e866d
   • Browse repository at this point

   Copy the full SHA

   d5e866d View commit details

   Browse the repository at this point in the history