Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undo strict racc dependency on this branch #687

Merged
merged 3 commits into from Mar 6, 2024
Merged

undo strict racc dependency on this branch #687

merged 3 commits into from Mar 6, 2024

Conversation

radar
Copy link
Collaborator

@radar radar commented Mar 6, 2024

This causes people's builds to break.

See #685 for the discussion.

Yes, this means i18n will not install on Ruby 3.3 until you also install the Racc gem.

This will be addressed in an upcoming 2.x release for i18n.

@radar radar marked this pull request as ready for review March 6, 2024 21:54
@radar radar merged commit 43f5e3a into master Mar 6, 2024
21 of 27 checks passed
@radar radar deleted the undo-racc-dep branch March 6, 2024 21:54
@radar
Copy link
Collaborator Author

radar commented Mar 6, 2024

Confirming this branch fixes the issue by:

  1. Running a Docker container of ruby:3.0-alpine
  2. Cloning this repo
  3. Running rake install
  4. Having that install succeed

On master (pre merge), this would do:

Running `gem install /home/i18n/pkg/i18n-1.14.3.gem` failed with the following output:

Building native extensions. This could take a while...
ERROR:  Error installing /home/i18n/pkg/i18n-1.14.3.gem:
	ERROR: Failed to build gem native extension.

    current directory: /usr/local/bundle/gems/racc-1.7.3/ext/racc/cparse
/usr/local/bin/ruby -I /usr/local/lib/ruby/3.0.0 -r ./siteconf20240306-49-cwb37a.rb extconf.rb
creating Makefile

current directory: /usr/local/bundle/gems/racc-1.7.3/ext/racc/cparse
make DESTDIR\= clean
current directory: /usr/local/bundle/gems/racc-1.7.3/ext/racc/cparse
make DESTDIR\=
make failedNo such file or directory - make

Gem files will remain installed in /usr/local/bundle/gems/racc-1.7.3 for inspection.
Results logged to /usr/local/bundle/extensions/aarch64-linux-musl/3.0.0/racc-1.7.3/gem_make.out


Tasks: TOP => install
(See full trace by running task with --trace)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant