Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use localized date and time formats in interpolate_hash #674

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use localized date and time formats in interpolate_hash #674

wants to merge 3 commits into from

Commits on Oct 16, 2023

  1. Reenable Time localization default test 

    Originally disabled in
518c053 (remove timezone sensible test because it breaks on windows, 2008-06-24)

Test now works in Windows 10, Ruby 3.2.2 (via 'RubyInstaller')
    @davidgumberg
    davidgumberg committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    667b055 View commit details
    Browse the repository at this point in the history

  2. Add tests to ensure localize defaults to :default

    @davidgumberg
    davidgumberg committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    1a9a775 View commit details
    Browse the repository at this point in the history

  3. Use localized date formats in interpolate_hash 

    Interpolated strings containing Times or Dates should respect
`:default` formatting options of locale.
    @davidgumberg
    davidgumberg committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    ffb18e9 View commit details
    Browse the repository at this point in the history