Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo: function is missing closing parenthesis #585

Merged
merged 2 commits into from Nov 25, 2021
Merged

Fix typo: function is missing closing parenthesis #585

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
555cfe5
Fix typo: function is missing closing parenthesis
patrickgramatowski Nov 20, 2021
0d81422
Fix rubocop issues
patrickgramatowski Nov 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions lib/i18n.rb
View file
Open in desktop
Expand Up @@ -261,14 +261,14 @@ def exists?(key, _locale = nil, locale: _locale, **options)
#
# Setting a Hash using Ruby:
#
# store_translations(:de, :i18n => {
# :transliterate => {
# :rule => {
# "ü" => "ue",
# "ö" => "oe"
# }
# }
# )
# store_translations(:de, i18n: {
# transliterate: {
# rule: {
# 'ü' => 'ue',
# 'ö' => 'oe'
# }
Comment on lines +266 to +269
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why rubocop sees this hash with '=>' syntax as valid.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As valid or invalid?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As valid, as far as I understand, rubocop should shout at me to change this but it actually does not do it and maybe it's because of multi-level nesting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radar so WDYT, should we stick to the rubocop convention and add something like this:

#     store_translations(:de, i18n: {
#                          transliterate: {
#                            rule: {
#                              'ü': 'ue',
#                              'ö': 'oe'
#                            }
#                          }
#                        })

or maybe stick to the existing convention like that:

    #     store_translations(:de, :i18n => {
    #       :transliterate => {
    #         :rule => {
    #           "ü" => "ue",
    #           "ö" => "oe"
    #         }
    #       }
    #     })

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing Rubocop doesn't mind if it's a string or a symbol in this case because it's not an ascii character. I don't know the exact reason, and I don't have a preference for one over the other.

# }
# })
#
# Setting a Proc:
#
Expand Down