Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default: nil with fallbacks #387

Merged
merged 1 commit into from Oct 10, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/i18n/backend/fallbacks.rb
Expand Up @@ -37,15 +37,16 @@ module Fallbacks
def translate(locale, key, options = {})
return super unless options.fetch(:fallback, true)
return super if options[:fallback_in_progress]
default = extract_non_symbol_default!(options) if options[:default]
original_default = options[:default]
extract_non_symbol_default!(options)

begin
options[:fallback_in_progress] = true
I18n.fallbacks[locale].each do |fallback|
begin
catch(:exception) do
result = super(fallback, key, options)
return result if (result.nil? && options.key?(:default) && options[:default].nil?) || !result.nil?
return result unless result.nil?
end
rescue I18n::InvalidLocale
# we do nothing when the locale is invalid, as this is a fallback anyways.
Expand All @@ -55,7 +56,7 @@ def translate(locale, key, options = {})
options.delete(:fallback_in_progress)
end

return super(locale, nil, options.merge(:default => default)) if default
return super(locale, nil, options.merge(:default => original_default)) if options.key?(:default)
throw(:exception, I18n::MissingTranslation.new(locale, key, options))
end

Expand Down
5 changes: 5 additions & 0 deletions test/backend/fallbacks_test.rb
Expand Up @@ -59,6 +59,11 @@ def setup
assert_equal({}, I18n.t(:missing_bar, :locale => :'de-DE', :default => {}))
end

test "returns the :de translation for a missing :'de-DE' when :default is nil" do
assert_equal 'Bar in :de', I18n.t(:bar, :locale => :'de-DE', :default => nil)
assert_nil I18n.t(:missing_bar, :locale => :'de-DE', :default => nil)
end

test "returns the :'de-DE' default :baz translation for a missing :'de-DE' when defaults contains Symbol" do
assert_equal 'Baz in :de-DE', I18n.t(:missing_foo, :locale => :'de-DE', :default => [:baz, "Default Bar"])
end
Expand Down