Revert "Don't allow nil to be submitted as a key to i18n.translate()" #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reverting this as it broke cancancan: CanCanCommunity/cancancan#415 @jcstringer: I think that because cancancan relies on this feature, we should leave it the behaviour as it was. Interested to hear your thoughts on this too. |
|
@radar I get it with cancancan being a popular gem and such but for the record my 2 cents is that we should not support passing nil as a key and that raising the error makes sense. There is some chatter in the related cancancan issue to that effect. So if the proposed change on that end is ever made it would be nice to see this work merged back in here. |
|
I'm also working on a fix for cancancan since IMO it's an issue on their side, not on i18n's. See here: CanCanCommunity/cancancan#416. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #236